Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Esper tweaks #79403

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 28, 2025

Summary

Mods "[Aftershock] Esper tweaks"

Purpose of change

Noticed that the esper downside EoC was only checking if you were a telepath, and this is an opportunity for some other maintenance changes.

Describe the solution

Change the effect ids used by telepathy to prevent any clashes with MoM. The old effects will be removed on loading if a character has them and the powers will use the new effects going forward.

Implement the activity-based training used in telekinesis to electrokinesis and telepathy

Edit the magic_type to take advantage of new fields. AFS psi costs full stamina whether you succeed or fail, and has a chance to cause pain on a failure (unless you're immune to pain).

Describe alternatives you've considered

Testing

Loaded up a Spark, used some powers and had ill effects, used the practice recipes and saw they used the new method.

Loaded up a Whisper and made sure the powers used the new effects

Additional context

Will lint later since GitHub.dev continually fails at it

@Standing-Storm Standing-Storm marked this pull request as draft January 28, 2025 18:04
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions labels Jan 28, 2025
@Standing-Storm Standing-Storm marked this pull request as ready for review January 30, 2025 15:26
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant