Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typify the last of mapgen #79413

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Specify the type of offset and total parameters in mapgen operations.

Describe the solution

Change the type from "point" to "point_rel_omt" for both parameters (and the corresponding ones with the unfortunate "grid" in their names, despite having nothing to do with submaps).

Describe alternatives you've considered

Leave the type of "total" unchanged as it's a dimension specification but not a relative one. Went with typing it as specifying scale was considered more valuable than not indicating a mildly misleading relative feature.

Testing

Compiled and loaded a save. It's all just a consistent type change, so failures should show up on compilation.

Additional context

This was skipped during the typification covering the "m" files as tracking down the actual type required more digging than what was considered warranted at the time. It turned out not that much more digging was required, though.

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 29, 2025
@GuardianDll GuardianDll merged commit 944ab30 into CleverRaven:master Jan 30, 2025
28 of 29 checks passed
@PatrikLundell PatrikLundell deleted the mapgen branch January 30, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants