-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add myself as No Hope maintainer, minor reorganisation/clean up #79547
Add myself as No Hope maintainer, minor reorganisation/clean up #79547
Conversation
While the military base is very much a loot piñata esp if you're familiar with the design I don't see any reason to limit peeps, if they want to avoid it they can choose to themselves (hopefully Milopetilo will finish totally overhauling the location soon anyway)
Very unfitting for the mods goal
Main readme moved to in-game help, split off the dev bits into CONTRIBUTING.md, renamed EoCs files to difficulty_options to make their purpose more obvious and discourage shoving all additional EoCs in with them.
I'm interested in hearing your rationale for adding back in the zombie revival mechanic. I'm not super familiar with the altered lore of no hope, so I had always assumed it was because of some story thing. |
I don't think there was any altered lore, NP just didn't like how zombie reviving worked so they turned it off. |
why not just make |
Bc that would be very ugly and would require the player to do pick the values on every save |
eeh, why, just on start should be fine? you can store it in some global variable |
I mean every character/world |
oh, so you mean just for the ability to save it in template? |
I mean ig, I don't really see the issue with it working like this, anyone who doesn't want to faff can just use the predefined difficulties (I appreciate it's inideal but I don't see that many peeps caring enough) |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Ah, I remember reading their explanation once. I don't know why they're gone, I know a few of the situations that happened, but it's a shame to lose NP's contributions. |
Summary
Infrastructure "Allow extending/deleting connect_groups/connects_to/rotates_to"
Purpose of change
Night managed to get themselves banned from the repo so No Hope is left without a maintainer.
Describe the solution
Add myself as maintainer to No Hope
Reorganise and update the docs
Allow extending/deleting connect_groups/connects_to/rotates_to
Minor extension of copy-from usage
Link to an external template mod to customise the difficulty past the options provided
Remove various changes No Hope makes that I deem as unfitting:
Unblacklist the military base
Add back zombie reviving
Remove altered stamina burn rate
Describe alternatives you've considered
Not adding back the military base - while the military base is very much a loot piñata esp if you're familiar with the design it seems overkill to remove it, if players want to avoid it they can choose to themselves and hopefully Milopetilo will finish totally overhauling the location soon anyway
Testing
Game compiles and loads
Additional context
If anyone is aware of NP having any intent to maintain a version out of repo I'm happy to port their PRs over as I deem fit but I've not seen anything to that effect yet. If NP sees this and wants to reach out you can dm me here or on discord.
Happy to talk about the potential future of No Hope's direction here or on discord (same username).