Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for loading chain that crashed on write #378

Merged
merged 4 commits into from
Aug 23, 2024
Merged

fixes for loading chain that crashed on write #378

merged 4 commits into from
Aug 23, 2024

Conversation

cmbant
Copy link
Collaborator

@cmbant cmbant commented Aug 22, 2024

Possible fix for #306

@cmbant cmbant changed the title fixes for loading chain than crashed on write fixes for loading chain that crashed on write Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (3defa82) to head (4f7ad49).

Files Patch % Lines
cobaya/tools.py 25.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   74.65%   74.57%   -0.09%     
==========================================
  Files         147      147              
  Lines       11195    11209      +14     
==========================================
+ Hits         8358     8359       +1     
- Misses       2837     2850      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmbant cmbant merged commit f9557f9 into master Aug 23, 2024
6 checks passed
@cmbant
Copy link
Collaborator Author

cmbant commented Aug 23, 2024

Merged for now. Alternative would be to check if last line ends in \n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*ERROR* Error when loading samples: The sum of logpriors in the sample is not consistent.
2 participants