Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s image content from PRs: Fix id in job step #11604

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

yuumasato
Copy link
Member

Description:

  • Assign an explicit id to the step which the output value comes from.
  • Renames shell variable name from pr-number to pr_number to avoid issues in step.run's shell environment.

Rationale:

Review Hints:

  • Needs to be merged to take effect.
  • The workflow_run always executes what is on the master branch.

Assign an id to the step and use it to reference the step from which the
output comes.
Given that the run command run in a shell environment, let's use
underscore intead of minus sign.
@yuumasato yuumasato added the OpenShift OpenShift product related. label Feb 19, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Feb 19, 2024

Code Climate has analyzed commit e24b49e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit 952cd7c into ComplianceAsCode:master Feb 19, 2024
43 of 44 checks passed
@yuumasato yuumasato deleted the assign_id_to_step branch February 19, 2024 15:03
@yuumasato yuumasato added this to the 0.1.73 milestone Feb 19, 2024
@Mab879 Mab879 added the Infrastructure Our content build system label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants