Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending and receiving messages #11

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

felixoppongwillborg
Copy link

][PT board URL( https://www.pivotaltracker.com/story/show/173511460 )

User Story

As a user

In order to use the app

I want to be able to send and receive messages

Changes proposed in this pull request:

  • Added test for both sending and receiving messages

What I have learned working on this feature:

  • how to work with two different factories and using Warden

Odeane and others added 20 commits June 24, 2020 15:27
…created a db migartion for add_missing_indices.mailboxer_engine
…user_session_path then wrote test to locate Email to make sure i was in the right path second test was for filling in email, password and then clickon log in button
…receive message. Rewrote test for sending and receiving messages all test pass
Copy link

@emtalen emtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not testing that the recipient actually receives the message, only that it is sent from the sender. Which is totally fine, but then you should change the description of the PR

end
end


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra lines

click_on 'Log in'
expect(page).to have_content 'Invalid Email or password.'
end
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be consistent with the indentation, use 2 spaces and not 4

expect(page).to have_content "Hej test"
end
end
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be consistent with the indentation, use 2 spaces and not 4

end



Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file if you are not using it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants