-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending and receiving messages #11
base: master
Are you sure you want to change the base?
Sending and receiving messages #11
Conversation
…p now loads on server
…created a db migartion for add_missing_indices.mailboxer_engine
…nd the button functions which pass
…user_session_path then wrote test to locate Email to make sure i was in the right path second test was for filling in email, password and then clickon log in button
…ick on inbox and then compose message
…receive message. Rewrote test for sending and receiving messages all test pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not testing that the recipient actually receives the message, only that it is sent from the sender. Which is totally fine, but then you should change the description of the PR
end | ||
end | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra lines
click_on 'Log in' | ||
expect(page).to have_content 'Invalid Email or password.' | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be consistent with the indentation, use 2 spaces and not 4
expect(page).to have_content "Hej test" | ||
end | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be consistent with the indentation, use 2 spaces and not 4
end | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file if you are not using it
][PT board URL( https://www.pivotaltracker.com/story/show/173511460 )
User Story
Changes proposed in this pull request:
What I have learned working on this feature: