Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel mod loading causes CMEs which result in create's creative tab missing entries #6222

Closed
IThundxr opened this issue Mar 7, 2024 · 80 comments
Labels
area: compatibility Issue only happens when other mods are present status: fixed in next release Issue will be fixed in the next release

Comments

@IThundxr
Copy link
Member

IThundxr commented Mar 7, 2024

Has been fixed in 0.5.1.h.

Latest Info:

The issue has been found and a fix has been implemented, no more debugging is needed and thank you to everyone who helped in finding the issue. #6222 (comment)

A patch with a fix is not out yet, once it is out this issue will be closed.

@GreatWester
Copy link

After doing some testing, I've found that ModernFix has been throwing some anomalous results regarding Create in a modpack my friends have thrown together. Might be worth further investigation?

@GreatWester
Copy link

Further to the above, with what rudimentary testing I've done, while Create is on its own ModernFix has no noticeable effects from what I've observed. However, when one starts adding addons and their dependencies the effects become more adverse.

I'd advise doing some testing on everyone's own machines to observe the effects as they seem to be random with no discernible pattern.

@VoidLeech
Copy link
Contributor

I've had this happen with two modpacks (Sinny's Summer Spices, and a bigger, private, slightly WIP one) that don't contain ModernFix, but very, very infrequently, which makes reproducing and confirming anything difficult. That is not to discredit the ModernFix theory, it might also cause it, but I make this comment because I have another candidate that might cause the issue.
I just had it happen again on the private pack (so mind the big log) and got an error that might suggest the issue is with Entity Culling, which is something my personal experiences have had in common.
I noted a couple of interesting log lines in Prism's log output, which is the log I've copied as the lines don't actually appear in my latest.log.
https://mclo.gs/4o2vZF8: Of note are lines 4645-4654, which don't appear during a session where the creative tab loads correctly.
For now I'll disable Entity Culling and supply logs if the problem occurs again.

@Chris6ix
Copy link

I've had this happen with two modpacks (Sinny's Summer Spices, and a bigger, private, slightly WIP one) that don't contain ModernFix, but very, very infrequently, which makes reproducing and confirming anything difficult. That is not to discredit the ModernFix theory, it might also cause it, but I make this comment because I have another candidate that might cause the issue. I just had it happen again on the private pack (so mind the big log) and got an error that might suggest the issue is with Entity Culling, which is something my personal experiences have had in common. I noted a couple of interesting log lines in Prism's log output, which is the log I've copied as the lines don't actually appear in my latest.log. https://mclo.gs/4o2vZF8: Of note are lines 4645-4654, which don't appear during a session where the creative tab loads correctly. For now I'll disable Entity Culling and supply logs if the problem occurs again.

This is a weird one. I have the same issue on my private modpack, that includes both ModernFix and Entity Culling, but if you look at the linked duplicate issues above, almost none of them have any of the 2 mods and still have the issue :/
There is even one (#5987) that seems to only have Create and JEI installed, and there is a comment which claims some FTB mods cause the same issue. Plus the fact that this ONLY happens with Create's items. All this makes me think it's an issue with Create itself, not another mod. If so many completely different mods break precisely only Create, then it's probably Create doing smth wrong.

@ChaosDogG
Copy link

I've only had this issue when adding some Create addons in a preexisting world, in most cases a new world fixes the problem

@Plite7067
Copy link

I just reproduced it by updating a world from 1.19 to 1.20.1 and changing some addons.
Here is an online link: https://gnomebot.dev/paste/397702104204050434/1225184091704525002/1225184091381567690
And here is a copy for when the online one expires:
latest.log
I am still on the world if anyone wants me to try anything.

@Plite7067
Copy link

I can't see anything in the latest.log. I'm trying to look through debug.log at the moment. https://gnomebot.dev/paste/397702104204050434/1225186286609104908/1225186286328090644

@Plite7067
Copy link

Plite7067 commented Apr 3, 2024

I had a backup of the 1.19 world, and it happened again with different items missing. Im going to try to reproduce it again without modernfix

@Plite7067
Copy link

still happened again - again nothing I could find in latest/debug log

@Plite7067
Copy link

Plite7067 commented Apr 3, 2024

I have heard rumours that it only started happening at create 5.1e - not sure how true that is though

@MFNmodding
Copy link

i tend to see it after crashes.

@X66Herobrine66X
Copy link

hi there, is there any update on this issue? it is making things very sad on my server and we're really wanting to use Create

The PR is merged, so it’ll be in the next release of Create. In the meantime, you can use the temp mixin fix IThundxr put together: https://nextcloud.ithundxr.dev/s/KAjGmnpj7bczoyr

When will that be though? It's been months :/

@Leclowndu93150
Copy link

never

@nospeedlimit4me
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

@nospeedlimit4me
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

Is it just a jar and I pop it in the mods folder?

@muppetenergy
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

Is it just a jar and I pop it in the mods folder?

i actually really wanna know as well, it doesn't seem to work for me but i might be doing something wrong

@Plite7067
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

Is it just a jar and I pop it in the mods folder?

yeah

@nospeedlimit4me
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

Is it just a jar and I pop it in the mods folder?

yeah

Are you sure ?!

@Plite7067
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

Is it just a jar and I pop it in the mods folder?

yeah

Are you sure ?!

yeah - it needs the latest version of create 1.20.1 as well

@nospeedlimit4me
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

Is it just a jar and I pop it in the mods folder?

yeah

Are you sure ?!

yeah - it needs the latest version of create 1.20.1 as well

Could I also use ftb chunks?

@Plite7067
Copy link

Hello! Small family server owner here. Could someone kindly explain how exactly this “fix” that is downloaded through this link I see is put into the files? Which files exactly? Any help is greatly appreciated!

Is it just a jar and I pop it in the mods folder?

yeah

Are you sure ?!

yeah - it needs the latest version of create 1.20.1 as well

Could I also use ftb chunks?

yeah? no reason why not

@muppetenergy
Copy link

https://nextcloud.ithundxr.dev/s/KAjGmnpj7bczoyr temporary mixin fix, needs latest create 1.20.1

does this need to be added to the server as well? or just client?

@nospeedlimit4me
Copy link

https://nextcloud.ithundxr.dev/s/KAjGmnpj7bczoyr temporary mixin fix, needs latest create 1.20.1

does this need to be added to the server as well? or just client?

I also have this question!!

@VoidLeech
Copy link
Contributor

It’s needed only client-side.

@Explode007
Copy link

Even with the mixin fix, the issue still seems to be present. Still seems a soup of mods breaks it.

@IThundxr
Copy link
Member Author

IThundxr commented Aug 8, 2024

Even with the mixin fix, the issue still seems to be present. Still seems a soup of mods breaks it.

Then whatever the issue is, it's caused by some other mod

@Explode007
Copy link

The only fix I have which has been working since this issue arose was reloading multiple times in a world until expected recipes appear. I Don't know if that clues at something.

For context, im trying to make a hard progression similar to terrafirmagreg, including using their core mod and im sure that core mod is breaking a lot of things. However, even without this mod the recipes bug out when creating a new world or sometimes when joining existing worlds.

@Laqota
Copy link

Laqota commented Aug 24, 2024

I believe this issue is more of a problem with Create versions that are older than 1.19.2, since Forge API changes I don't believe it's even creates fault.

While you can still find items when searching for them, the tab doesn't have all the items. The reason for this is possibly because of the trashy, forge updates for version higher than 1.19.2 which introduced API changes. It's possible forge added some sort of anti-spam delay on the Item.Properties().tab() function since it does use a fair bit of Memory during the loading process, possibly to make the loading smoother if you have a lot of mods. (Possibly ruining some mods)

This, is possibly not allowing some items to register in the tabs. I think the only way for create to start functioning is if they run the tab function one by one with a slight delay instead of at once.e

@IThundxr
Copy link
Member Author

I believe this issue is more of a problem with Create versions that are older than 1.19.2, since Forge API changes I don't believe it's even creates fault.

While you can still find items when searching for them, the tab doesn't have all the items. The reason for this is possibly because of the trashy, forge updates for version higher than 1.19.2 which introduced API changes. It's possible forge added some sort of anti-spam delay on the Item.Properties().tab() function since it does use a fair bit of Memory during the loading process, possibly to make the loading smoother if you have a lot of mods. (Possibly ruining some mods)

This, is possibly not allowing some items to register in the tabs. I think the only way for create to start functioning is if they run the tab function one by one with a slight delay instead of at once.e

The cause is already known, none of what you've said causes this.

@sbmelvin
Copy link

sbmelvin commented Aug 27, 2024

https://nextcloud.ithundxr.dev/s/KAjGmnpj7bczoyr temporary mixin fix, needs latest create 1.20.1

Just wanted to share my experience with this fix. I used to have the missing item bug almost every time I launched MC, but I haven't experienced it since adding the fix. I asked other players on my server and they also said the fix resolved their missing item issues too.

@IThundxr
Copy link
Member Author

IThundxr commented Sep 3, 2024

This issue has been fixed in 0.5.1.h, if anyone is using the temporary mixin fix please note that it is not needed once you update to 0.5.1.h

@vaqxai
Copy link

vaqxai commented Nov 14, 2024

Still have this problem on create 0.5.1i

@Trisfol
Copy link

Trisfol commented Nov 18, 2024

Still have this problem on create 0.5.1i

Same here, i got lot of mods and create addons. I've been using create mod .f for like 1 month and no problem but since today, it won't display any create items on JEI exept a few. Tried to update JEI and create but it won't do anything.
Just tried to restart my LAN server and it appeared again. But i think there is sometimes a loading problem.

create

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compatibility Issue only happens when other mods are present status: fixed in next release Issue will be fixed in the next release
Projects
None yet
Development

No branches or pull requests