Add low-fi record induction outcome #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteryates
added
the
Deploy
peteryates
force-pushed
the
ab-record-induction-outcome
branch
2 times, most recently
from
0c277bf
to
d066ec4
Compare
peteryates
force-pushed
the
ab-record-induction-outcome
branch
from
d066ec4
to
15d9050
Compare
|
Review app deployed to https://cpd-ec2-review-405-web.test.teacherservices.cloud |
This will be used to record the pass/fail state for inductions. Not all submissions will have one so it's nullable. For now we just have pass/fail but there might be other ones in the future.
peteryates
force-pushed
the
ab-record-induction-outcome
branch
from
15d9050
to
e20bf9e
Compare
edujackedu
reviewed
Oct 7, 2024
| # period and send an update to TRS with the | ||
| # outcome and finish date | ||
|
|
||
| true |
There was a problem hiding this comment.
do we want to have a way to fail this for testing/user research purposes?
There was a problem hiding this comment.
Maybe, I think we can deal with that when we tackle the actual recording process though.
edujackedu
approved these changes
Oct 7, 2024
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This largely follows the release ECT pattern except it also captures the outcome (pass or fail).
The proper text, question order, etc will be decided on later.