Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVVIS driver and tests #546

Merged
merged 12 commits into from
Aug 28, 2023
Merged

UVVIS driver and tests #546

merged 12 commits into from
Aug 28, 2023

Conversation

antonhibl
Copy link
Contributor

No description provided.

acpaquette
acpaquette previously approved these changes Jul 17, 2023
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good now! I am going to approve and hopefully that will get tests running. If those pass this can be merged

removing notebook, accidentally included

notebook changes

Fixes code.json for release

Adds 0.8.7 to main

initial driver tests, these still need working on.

adding test kernels

staging tests

typo in function

debugging

added additonal kernels and more debugging

changed label name
changed label

import fix

test fixes
@codecov-commenter
Copy link

Codecov Report

Merging #546 (12078a5) into main (5965330) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   16.91%   16.80%   -0.12%     
==========================================
  Files          54       55       +1     
  Lines        5865     5904      +39     
==========================================
  Hits          992      992              
- Misses       4873     4912      +39     
Files Changed Coverage Δ
ale/drivers/clementine_drivers.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@acpaquette acpaquette merged commit 99d0ff0 into DOI-USGS:main Aug 28, 2023
12 checks passed
@antonhibl antonhibl deleted the uvvis-driver branch August 28, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants