Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallelize next plugin test #4343

Merged
merged 3 commits into from
May 30, 2024
Merged

parallelize next plugin test #4343

merged 3 commits into from
May 30, 2024

Conversation

bengl
Copy link
Collaborator

@bengl bengl commented May 22, 2024

What does this PR do?

See title

Motivation

It's very slow otherwise (>10min)

Copy link

github-actions bot commented May 22, 2024

Overall package size

Self size: 6.55 MB
Deduped: 61.81 MB
No deduping: 62.09 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@bengl bengl marked this pull request as ready for review May 22, 2024 19:13
@bengl bengl requested a review from a team as a code owner May 22, 2024 19:14
@rochdev
Copy link
Member

rochdev commented May 22, 2024

Any way to revert this PR instead? #3935

There was already logic in place before to split not only by Node version but also by Next version which brought this down to ~2min.

@bengl
Copy link
Collaborator Author

bengl commented May 22, 2024

Any way to revert this PR instead? #3935

There was already logic in place before to split not only by Node version but also by Next version which brought this down to ~2min.

I'd rather not, because that leaves us with two places where version ranges for this plugin are defined.

@bengl bengl requested a review from a team as a code owner May 22, 2024 21:00
@bengl bengl enabled auto-merge (squash) May 29, 2024 19:17
Copy link
Member

@tlhunter tlhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have passed
36 successful checks

Shouldn't this number be over 100?

Qard
Qard previously approved these changes May 29, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 29, 2024

Benchmarks

Benchmark execution time: 2024-05-30 14:18:54

Comparing candidate commit 33eb4ed in PR branch bengl/parallelize-next with baseline commit 557814a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics.

@@ -7,6 +7,9 @@ on:
schedule:
- cron: '0 4 * * *'

env:
OLDEST_NODE: 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be merged to v4 no ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean dont we support node 16 in v4 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just replaces some existing hard-coded instances of 18 in this file. Presumably we'd need to backport this to the v4 release branch separately, with 16 here, but I'm not sure what's currently on that branch. I haven't looked.

@bengl
Copy link
Collaborator Author

bengl commented May 30, 2024

@tlhunter

Shouldn't this number be over 100?

Yep. Looks like the workflow file might be invalid. I'll fix that.

@bengl bengl merged commit 2d8b5af into master May 30, 2024
120 checks passed
@bengl bengl deleted the bengl/parallelize-next branch May 30, 2024 15:36
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
* parallelize next plugin test

* also parallelize in appsec, and use OLDEST_NODE env var
juan-fernandez pushed a commit that referenced this pull request Jun 4, 2024
* parallelize next plugin test

* also parallelize in appsec, and use OLDEST_NODE env var
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
* parallelize next plugin test

* also parallelize in appsec, and use OLDEST_NODE env var
juan-fernandez pushed a commit that referenced this pull request Jun 5, 2024
* parallelize next plugin test

* also parallelize in appsec, and use OLDEST_NODE env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants