-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallelize next plugin test #4343
Conversation
Overall package sizeSelf size: 6.55 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
7b14bcc
to
a99e11b
Compare
Any way to revert this PR instead? #3935 There was already logic in place before to split not only by Node version but also by Next version which brought this down to ~2min. |
I'd rather not, because that leaves us with two places where version ranges for this plugin are defined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks have passed
36 successful checks
Shouldn't this number be over 100?
fda367c
to
539ec46
Compare
.github/workflows/appsec.yml
Outdated
@@ -7,6 +7,9 @@ on: | |||
schedule: | |||
- cron: '0 4 * * *' | |||
|
|||
env: | |||
OLDEST_NODE: 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't be merged to v4 no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean dont we support node 16 in v4 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just replaces some existing hard-coded instances of 18
in this file. Presumably we'd need to backport this to the v4 release branch separately, with 16
here, but I'm not sure what's currently on that branch. I haven't looked.
539ec46
to
1140b4e
Compare
Yep. Looks like the workflow file might be invalid. I'll fix that. |
* parallelize next plugin test * also parallelize in appsec, and use OLDEST_NODE env var
* parallelize next plugin test * also parallelize in appsec, and use OLDEST_NODE env var
* parallelize next plugin test * also parallelize in appsec, and use OLDEST_NODE env var
* parallelize next plugin test * also parallelize in appsec, and use OLDEST_NODE env var
What does this PR do?
See title
Motivation
It's very slow otherwise (>10min)