Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallelize next plugin test #4343

Merged
merged 3 commits into from
May 30, 2024
Merged

parallelize next plugin test #4343

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4652d2
parallelize next plugin test
bengl May 22, 2024
1140b4e
also parallelize in appsec, and use OLDEST_NODE env var
bengl May 22, 2024
33eb4ed
de-variable-ize the oldest node version, since it doesn't work there.
bengl May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/appsec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
schedule:
- cron: '0 4 * * *'

env:
OLDEST_NODE: 18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be merged to v4 no ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean dont we support node 16 in v4 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just replaces some existing hard-coded instances of 18 in this file. Presumably we'd need to backport this to the v4 release branch separately, with 16 here, but I'm not sure what's currently on that branch. I haven't looked.


concurrency:
group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
cancel-in-progress: true
Expand Down Expand Up @@ -202,17 +205,22 @@ jobs:
- uses: codecov/codecov-action@v3

next:
strategy:
matrix:
version:
- ${{ env.OLDEST_NODE }}
- latest
runs-on: ubuntu-latest
env:
PLUGINS: next
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/testagent/start
- uses: ./.github/actions/node/setup
- uses: actions/setup-node@v3
with:
cache: yarn
node-version: ${{ matrix.version }}
- run: yarn install
- uses: ./.github/actions/node/oldest
- run: yarn test:appsec:plugins:ci
- uses: ./.github/actions/node/latest
- run: yarn test:appsec:plugins:ci
- if: always()
uses: ./.github/actions/testagent/logs
Expand Down
16 changes: 12 additions & 4 deletions .github/workflows/plugins.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
schedule:
- cron: '0 4 * * *'

env:
OLDEST_NODE: 18

concurrency:
group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
cancel-in-progress: true
Expand Down Expand Up @@ -935,17 +938,22 @@ jobs:

# TODO: fix performance issues and test more Node versions
next:
strategy:
matrix:
version:
- ${{ env.OLDEST_NODE }}
- latest
runs-on: ubuntu-latest
env:
PLUGINS: next
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/testagent/start
- uses: ./.github/actions/node/setup
- uses: actions/setup-node@v3
with:
cache: yarn
node-version: ${{ matrix.version }}
- run: yarn install
- uses: ./.github/actions/node/oldest
- run: yarn test:plugins:ci
- uses: ./.github/actions/node/latest
- run: yarn test:plugins:ci
- if: always()
uses: ./.github/actions/testagent/logs
Expand Down
Loading