Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin import-in-the-middle to 1.11.0 #4732

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Sep 27, 2024

What does this PR do?

Pin import-in-the-middle dependency to 1.11.0.

Motivation

It seems the latest release of import-in-the-middle has broken something: https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.11.1

Specifically, it breaks our vitest integration by throwing this error

/private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/import-in-the-middle/lib/register.js:20
    return getters.get(target)[name]()
                                    ^

TypeError: getters.get(...)[name] is not a function
    at Object.get (/private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/import-in-the-middle/lib/register.js:20:37)
    at /private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/dd-trace/packages/datadog-instrumentations/src/helpers/hook.js:41:40
    at callHookFn (/private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/import-in-the-middle/index.js:29:22)
    at Hook._iitmHook (/private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/import-in-the-middle/index.js:150:11)
    at /private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/import-in-the-middle/lib/register.js:37:31
    at Array.forEach (<anonymous>)
    at register (/private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/import-in-the-middle/lib/register.js:37:15)
    at file:///private/var/folders/t1/rs2htfh55mz9px2j4prmpg_c0000gq/T/224f78e3fac620df/node_modules/vitest/dist/vendor/constants.5J7I254_.js?iitm=true:104:1
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)

Related fix in iitm: nodejs/import-in-the-middle#155

@juan-fernandez juan-fernandez marked this pull request as ready for review September 27, 2024 09:12
@juan-fernandez juan-fernandez requested a review from a team as a code owner September 27, 2024 09:12
Copy link

Overall package size

Self size: 7.19 MB
Deduped: 62.59 MB
No deduping: 62.87 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.11.0 | 110.74 kB | 824.21 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2024

Benchmarks

Benchmark execution time: 2024-09-27 09:25:31

Comparing candidate commit ab31848 in PR branch juan-fernandez/fix-iitm-version with baseline commit 65d50b4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

Copy link

@breadadams breadadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you guys need an internal approval too, but here's mine 🙂

@crysmags crysmags merged commit 754abe0 into master Sep 27, 2024
193 of 194 checks passed
@crysmags crysmags deleted the juan-fernandez/fix-iitm-version branch September 27, 2024 13:39
@karrui
Copy link

karrui commented Sep 30, 2024

When will the dd-trace release happen to fix this bug? Still affecting the Test Visibility action

karrui added a commit to opengovsg/isomer that referenced this pull request Sep 30, 2024
`import-in-the-middle` v1.11.0 release broke datadog's vitest test visibility tracing. 

This PR temporarily disables the visibility harness for unit tests (playwright not affected) until it's fixed.

Related:
* DataDog/dd-trace-js#4732
* nodejs/import-in-the-middle#155


## Solution

This change disables the Datadog Test Visibility configuration and tracing in the CI workflow for the isomer-studio project.

**Breaking Changes**

- [x] No - this PR is backwards compatible

**Improvements**:

- Removed Datadog Test Visibility configuration step from the CI workflow
- Commented out Datadog-related environment variables for the test run

## Tests

No new tests are required for this change. Existing tests should continue to run without Datadog tracing.
juan-fernandez added a commit that referenced this pull request Sep 30, 2024
@juan-fernandez juan-fernandez mentioned this pull request Sep 30, 2024
juan-fernandez added a commit that referenced this pull request Sep 30, 2024
@juan-fernandez juan-fernandez mentioned this pull request Sep 30, 2024
@timfish
Copy link

timfish commented Sep 30, 2024

[email protected] has been released now.

juan-fernandez added a commit that referenced this pull request Oct 1, 2024
juan-fernandez added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants