-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for PID controlled pump #482
Comments
Regarding the test of the controlled pump flowing out into fractional flow nodes: this possibility is also not covered yet in function update_jac_prototype!(
jac_prototype::SparseMatrixCSC{Float64, Int64},
p::Parameters,
node::PidControl,
)::Nothing |
Regarding the following:
In order to do this, the |
Fixes #347. See #482 what has to be done related to this. --------- Co-authored-by: Bart de Koning <[email protected]>
Paused this for now, we'll probably work on #152 first. Until then |
New cases for PID control to be tested emerged due to refactoring (#474, #465). These test cases are:
FractionalFlow
nodes;LinearResistance
. This could be added to the equation test by connecting aLevelBoundary
viaLinearResistance
to the PID controlled basin. This was first trought to be hard to support (Stricter PID connectivity validation #481) but it seems to be supported now;LevelBoundary
node (done in Add weir #485).The text was updated successfully, but these errors were encountered: