Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for PID controlled pump #482

Closed
2 of 4 tasks
Tracked by #428
SouthEndMusic opened this issue Aug 4, 2023 · 3 comments
Closed
2 of 4 tasks
Tracked by #428

Tests for PID controlled pump #482

SouthEndMusic opened this issue Aug 4, 2023 · 3 comments
Assignees
Labels
control Rule based control of physical layer test Relates to unit testing

Comments

@SouthEndMusic
Copy link
Collaborator

SouthEndMusic commented Aug 4, 2023

New cases for PID control to be tested emerged due to refactoring (#474, #465). These test cases are:

  • The PID controlled pump flowing out into FractionalFlow nodes;
  • The PID controlled basin influencing itself trough being connected to e.g. a LinearResistance. This could be added to the equation test by connecting a LevelBoundary via LinearResistance to the PID controlled basin. This was first trought to be hard to support (Stricter PID connectivity validation #481) but it seems to be supported now;
  • The PID controlled basin getting in the 'reduction factor regime' (although this is probably quite rare in practice).
  • Upstream of the PID controlled weir is a LevelBoundary node (done in Add weir #485).
@SouthEndMusic SouthEndMusic added test Relates to unit testing control Rule based control of physical layer labels Aug 4, 2023
@SouthEndMusic SouthEndMusic changed the title Add test for PID controlled pump flowing to FractionalFlow Add tests for PID controlled pump Aug 7, 2023
@SouthEndMusic
Copy link
Collaborator Author

Regarding the test of the controlled pump flowing out into fractional flow nodes: this possibility is also not covered yet in

function update_jac_prototype!(
    jac_prototype::SparseMatrixCSC{Float64, Int64},
    p::Parameters,
    node::PidControl,
)::Nothing

@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Aug 9, 2023

Regarding the following:

The PID controlled basin influencing itself trough being connected to e.g. a LinearResistance

In order to do this, the $\frac{\partial E}{\partial u_i}$ (see equations.qmd in #485) are needed. Most of these are $0$; a nice method has to be found to figure out which aren't (currently they aren't incorporated at all).

@SouthEndMusic SouthEndMusic mentioned this issue Aug 9, 2023
Huite pushed a commit that referenced this issue Aug 11, 2023
Fixes #347.

See #482 what has to be done
related to this.

---------

Co-authored-by: Bart de Koning <[email protected]>
@gijsber gijsber changed the title Add tests for PID controlled pump Extend Jacobian and apply in tests for PID controlled pump Aug 17, 2023
@visr
Copy link
Member

visr commented Aug 25, 2023

Paused this for now, we'll probably work on #152 first. Until then jac = false can be used for any models for which the Jacobian is not complete.

@visr visr changed the title Extend Jacobian and apply in tests for PID controlled pump Tests for PID controlled pump Aug 31, 2023
@visr visr closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control Rule based control of physical layer test Relates to unit testing
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants