Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weir #485

Merged
merged 13 commits into from
Aug 11, 2023
Merged

Add weir #485

merged 13 commits into from
Aug 11, 2023

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Aug 8, 2023

Fixes #347.

See #482 what has to be done related to this.

@SouthEndMusic SouthEndMusic marked this pull request as draft August 8, 2023 15:11
@SouthEndMusic SouthEndMusic mentioned this pull request Aug 9, 2023
4 tasks
@SouthEndMusic SouthEndMusic marked this pull request as ready for review August 9, 2023 11:21
Copy link
Contributor

@Huite Huite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm no longer intimately familiar with the code base, this looks good to me -- the change is also somewhat minor as the weir is arguably just a Pump alias.

I think "weir" is maybe not the best term: it's explicitly a weir that maintains the level. I don't think the name has to be a blocker, but maybe it's worth keeping an issue for it.

What would be good to change before merging is to resolve the auto-generated code coverage remarks. Ideally the output is tested as well, but this is often difficult (hence 100% coverage doesn't mean 100% reliable). However, given that Julia is a dynamic language, it would be good that (nearly) all lines run during a test.

core/src/solve.jl Outdated Show resolved Hide resolved
@SouthEndMusic
Copy link
Collaborator Author

Many of the changes in this PR also affect Pump (mainly in jac.jl). Not all of it is tested, but this is covered in #482.

@Huite Huite merged commit 2d2590c into main Aug 11, 2023
18 checks passed
@Huite Huite deleted the Add_weir branch August 11, 2023 08:08
core/src/jac.jl Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add weir object with opposite characteristics of pump
3 participants