Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionality: Occurrence / Concurrence / Transferrence / Commemorations #3438

Merged
merged 7 commits into from
Nov 25, 2023

Conversation

FAJ-Munich
Copy link
Contributor

Motivated by so many recent issues (e.g., #3418, #3416, #3348, #3347, #3211, and #2970) regarding wrong commemorations (either wrong order, missing due to transferred feasts, or showing up transferred together with some other feasts) that required manual workarounds and multiple database files for one and the same feast dependent on the date of Easter, I reworked the getrank() and oratio() routine, effectively replacing the former by two new functions occurrence() and concurrence(). In addition, the following changes are contained within the package:

  1. The new routines build on a re-balanced ranking of offices to simplify the necessary if-else for the various rubrical structures. Please refer to the table built into technical.html for reference.
  2. To avoid ranking mismatches for the various vulgar languages and to reduce redundancies, I have made the code ignore everything in the [Rank] hash of non Latin files after the first ;;. Thus, it is still possible to translate a Saints or Feasts name to a local language without the risk of assigning a deviating numerical rank or Common.
  3. To allow for separate transferal of feasts and their associated commemorations on their original dates, I opened the possibility to define commemorated offices within the Kalendarium and Transfer files. Again, please have a look at the technical.html description for examples. Basically, I use a '~' char in between offices like 01-11=01-11~01-11cc=S. Hilarius... for instance. I have tried it privately and can use the method also to define Diocesan propers as wished for long time ago in Options for diocesan propers #423
  4. Sorting out the Transferal and Commemorations of the Domincia infra 8vam Nativitatis especially under Tridenting rubrics required me to split away the temporal aspect of the Octave from the feasts: therefore, there are new files Nat26.txt ... Nat31.txt in the Tempora folder supplementing the offices 12-26.txt ... 12-30.txt as before. Comparing the Matins readings in the Divino Afflatu version with the books from 1888 and 1906, I noticed a difference in the Tridentine version which has not been addressed by the database yet. I hope to incorporate these changes in time before Christmas. I've seen discussions on that reaching as far back as Ninth lesson for commemoration of Sunday in the octave of Christmas missing #2125 and Dominica infra Octavam Nativitatis #1062 which have been addressed for the post DA version by Fix #1060 #1062 #2117.
  5. Following our discussion on 1888 Tridentine rankings need to be checked #3421, Introduction of the Tridentine 1906 calendar: (courtesy to @mbab for providing the "diff" on the Kalendarium) I don't like removing existing functionalities from the project, so 1906 does not replace 1888 but supplements it now.
  6. As the new Kalendarium 1906 requires new transferals and since the 1570 transferrals of Semiduplex and Duplex minus have been missing, I reduced the redundancy of transfer lines in the files by introducing separate files a.txt ... g.txt for the common transfers by Dominical Letter. I have completed the files relevant for 2023 and 2024 to buy some time to finish the rest. The transfers of Scripture is a separate topic to be addressed at some point in the future.
  7. Last but not least, I have propagated the changes to the missa folders to the best of my knowledge and understanding. I am sure their is open work to do which I have not noticed unfortunately.

Laudetur Jesus Christus!

New functionalities (code only):

Occurence() and Concurrence() to replace getrank()
Commemorations: option to assign seperately in Kalendarium and/or Transfers
Transfers by Dominical Letter
new Kalendarium
updated Transfer files (work completed for 2023 and 2024)
making use of defining common transfers per Dominical Letter
Separating Temporal and Sanctoral elements to allow proper transfers of the Sunday and S. Thomas Becket
for certain Saints relevant for 2023 and 2024 and applying it to the recent issues DivinumOfficium#3418 DivinumOfficium#3416 DivinumOfficium#3348 DivinumOfficium#3347 DivinumOfficium#3211 and DivinumOfficium#2970 in particular.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants