Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compose bom version 2023.09.00 #1215

Merged
merged 7 commits into from
Sep 16, 2023

Conversation

matsumo0922
Copy link
Contributor

Issue

  • N/A

Overview (Required)

  • Changed version control of Compose to be done by Bom
  • Compose Bom version is set to 2023.09.00

Links

@matsumo0922 matsumo0922 requested a review from a team as a code owner September 14, 2023 15:50
@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Test Results

215 tests   215 ✔️  7m 31s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 1339a66.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Hi @matsumo0922! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 14, 2023 17:01 Inactive
@github-actions
Copy link

Snapshot diff report

File name Image
SponsorsScreenTest.c
heckScrollShot_compa
re.png
SponsorsScreenTest.c
heckScrollShot_2_com
pare.png
SponsorsScreenTest.c
heckLaunchShot_compa
re.png
TimetableScreenTest.
checkGridScrollShot_
compare.png
TimetableScreenTest.
checkLaunchServerErr
orShot_compare.png
BookmarkScreenTest.c
heckBookmarkToggleSh
ot_compare.png
SearchScreenTest.che
ckFilterLanguageChip
Shot_compare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay1AndDay3Shot_co
mpare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay1AndDay2Shot_co
mpare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay2Shot_compare.p
ng
TimetableItemDetailS
creenTest.checkScrol
lShot_3_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_compare.png
TimetableItemDetailS
creenTest.checkLarge
FontScaleShot_compar
e.png
TimetableItemDetailS
creenTest.checkBookm
arkToggleShot_compar
e.png
TimetableItemDetailS
creenTest.checkLaunc
hShot_compare.png
TimetableItemDetailS
creenTest.checkReadM
oreExpansionShot_com
pare.png
TimetableItemDetailS
creenTest.checkLaunc
hAccessibilityShot_c
ompare.png
SearchScreenTest.che
ckFilterDayChipShot_
2_compare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay1Shot_compare.p
ng
TimetableScreenTest.
checkHugeFontScaleSh
ot_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_4_compare.png
TimetableScreenTest.
checkLaunchAccessibi
lityShot_compare.png
SearchScreenTest.che
ckFilterSessionTypeC
hipShot_compare.png
SearchScreenTest.che
ckFilterLanguageChip
Shot_2_compare.png
SearchScreenTest.che
ckLaunchShot_compare
.png
SearchScreenTest.che
ckLargeFontScaleShot
_compare.png
SearchScreenTest.che
ckFilterLanguageChip
Shot_3_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_2_compare.png
TimetableItemDetailS
creenTest.checkReadM
oreExpansionShot_2_c
ompare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay3Shot_compare.p
ng
TimetableScreenTest.
checkGridShot_compar
e.png
SearchScreenTest.che
ckEmptyBodyShot_comp
are.png
TimetableScreenTest.
checkSmallFontScaleS
hot_compare.png
TimetableScreenTest.
checkScrollShot_comp
are.png
TimetableScreenTest.
checkLargeFontScaleS
hot_compare.png
SearchScreenTest.che
ckFilterDayChipShot_
3_compare.png
SearchScreenTest.che
ckHugeFontScaleShot_
compare.png
TimetableItemDetailS
creenTest.checkHugeF
ontScaleShot_compare
.png
SearchScreenTest.che
ckFilterDayChipShot_
compare.png
TimetableScreenTest.
checkLaunchShot_comp
are.png
SearchScreenTest.che
ckFilterSessionTypeC
hipShot_3_compare.pn
g
SearchScreenTest.che
ckSmallFontScaleShot
_compare.png
SearchScreenTest.che
ckFilterSessionTypeC
hipShot_2_compare.pn
g
SearchScreenTest.che
ckFilterCategoryChip
Shot_compare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay2AndDay3Shot_co
mpare.png
BookmarkScreenTest.c
heckLaunchEmptyShot_
compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_2_compare.png
SearchScreenTest.che
ckFilterCategoryChip
Shot_2_compare.png
SearchScreenTest.che
ckFilterCategoryChip
Shot_3_compare.png
BookmarkScreenTest.c
heckLaunchNotEmptySh
ot_compare.png
FloorMapScreenTest.c
heckChangeFloorShot_
compare.png
FloorMapScreenTest.c
heckLaunchShot_compa
re.png
AboutScreenTest.chec
kLaunchShot_compare.
png
AboutScreenTest.chec
kScrollShot_3_compar
e.png
AboutScreenTest.chec
kScrollShot_compare.
png
AboutScreenTest.chec
kScrollShot_2_compar
e.png
AchievementsScreenTe
st.checkLaunchShot_c
ompare.png
AchievementsScreenTe
st.checkLaunchShot_2
_compare.png
io.github.droidkaigi
.confsched2023.floor
map.component_null_T
heme_FloorLevelSwitc
herPreview-LightMode
-1_1_null_1_compare.
png
io.github.droidkaigi
.confsched2023.sessi
ons_null_Theme_Previ
ewTimetableScreenDar
k-DarkMode-1_2_null_
compare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Them
e_AboutDroidKaigiDet
ailSummaryCardPrevie
w-LightMode-2_2_null
_compare.png
io.github.droidkaigi
.confsched2023.floor
map.section_null_The
me_BasementFloorMapP
review-DarkMode-3_4_
null_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_EmptySearchResu
ltBodyPreview-DarkMo
de-4_5_null_compare.
png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-DarkMode-1
2_13_null_0_compare.
png
io.github.droidkaigi
.confsched2023.spons
ors.section_null_The
me_SponsorListPrevie
w-DarkMode-2_3_null_
compare.png
KaigiAppTest.checkNa
vigateToFloorMapShot
_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTabPre
view-DarkMode-23_24_
null_compare.png
KaigiAppTest.checkSt
artupShot_compare.pn
g
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableItemDe
tailSummaryCardRowPr
eview-DarkMode-20_21
_null_compare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Lang
uage_AboutFooterLink
sPreview-Japanese-4_
6_null_compare.png
KaigiAppTest.checkNa
vigateToSearchShot_c
ompare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Them
e_AboutDroidKaigiDet
ailSummaryCardRowPre
view-DarkMode-3_4_nu
ll_compare.png
io.github.droidkaigi
.confsched2023.spons
ors.section_null_Lan
guage_SponsorListPre
view-English-2_5_nul
l_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_L
anguage_PreviewTimet
ableGridItem-Japanes
e-4_6_null_compare.p
ng
io.github.droidkaigi
.confsched2023.about
.component_null_Them
e_AboutOthersPreview
-LightMode-6_6_null_
compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_TimetableTabRow
Preview-LightMode-24
_24_null_compare.png
io.github.droidkaigi
.confsched2023.floor
map.section_null_The
me_GroundFloorMapPre
view-DarkMode-4_5_nu
ll_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_EmptySearchResu
ltBodyPreview-LightM
ode-4_4_null_compare
.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-DarkMode-1
2_13_null_2_compare.
png
io.github.droidkaigi
.confsched2023.floor
map_null_Language_Pr
eviewFloorMapScreen-
Japanese-0_2_null_co
mpare.png
io.github.droidkaigi
.confsched2023.sessi
ons_null_Theme_Previ
ewTimetableScreenDar
k-LightMode-1_1_null
_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-DarkMode-1
2_13_null_1_compare.
png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_SessionTagPrevi
ew-LightMode-10_10_n
ull_compare.png
io.github.droidkaigi
.confsched2023.staff
.component_null_Defa
ultGroup_StaffListIt
emPreview_0_null_1_c
ompare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-DarkMode-1
2_13_null_6_compare.
png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-LightMode-
12_12_null_5_compare
.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridMultiSpeakersIt
em-LightMode-11_11_n
ull_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_L
anguage_ReadMoreOutl
inedButtonPreview-En
glish-7_10_null_comp
are.png
io.github.droidkaigi
.confsched2023.about
.component_null_Lang
uage_AboutFooterLink
sPreview-English-4_7
_null_compare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Lang
uage_AboutDroidKaigi
DetailSummaryCardPre
view-English-2_5_nul
l_compare.png
io.github.droidkaigi
.confsched2023.floor
map.component_null_T
heme_PreviewFloorMap
SideEventItem-LightM
ode-2_2_null_compare
.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_L
anguage_TimetableIte
mDetailSummaryCardRo
wPreview-Japanese-11
_13_null_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_Lan
guage_TimetablePrevi
ew-English-16_19_nul
l_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_SearchFilterPrevi
ew-LightMode-27_27_n
ull_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-LightMode-
12_12_null_1_compare
.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_L
anguage_PreviewTimet
ableGridItem-English
-4_7_null_compare.pn
g
io.github.droidkaigi
.confsched2023.sessi
ons.section_null_The
me_SearchFilterPrevi
ew-DarkMode-27_28_nu
ll_compare.png
io.github.droidkaigi
.confsched2023.about
.component_null_Them
e_AboutFooterLinksPr
eview-DarkMode-4_5_n
ull_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-LightMode-
12_12_null_4_compare
.png
io.github.droidkaigi
.confsched2023.desig
nsystem.theme_null_D
efaultGroup_FontPrev
iew_0_null_compare.p
ng
KaigiAppTest.checkNa
vigateToAboutShot_co
mpare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItemWelcomeTalk
-DarkMode-13_14_null
_compare.png
io.github.droidkaigi
.confsched2023.floor
map.component_null_T
heme_FloorLevelSwitc
herPreview-DarkMode-
1_2_null_0_compare.p
ng
io.github.droidkaigi
.confsched2023.floor
map.section_null_The
me_BasementFloorMapP
review-LightMode-3_3
_null_compare.png
KaigiAppTest.checkTi
metableTabs_2_compar
e.png
io.github.droidkaigi
.confsched2023.about
.component_null_Them
e_AboutDroidKaigiDet
ailPreview-LightMode
-1_1_null_compare.pn
g
io.github.droidkaigi
.confsched2023.floor
map.component_null_L
anguage_PreviewFloor
MapSideEventItem-Eng
lish-1_4_null_compar
e.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-LightMode-
12_12_null_3_compare
.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_L
anguage_PreviewTimet
ableGridLongTitleIte
m-Japanese-5_7_null_
compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridMultiSpeakersIt
em-DarkMode-11_12_nu
ll_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_DescriptionSect
ionPreview-LightMode
-15_15_null_compare.
png
KaigiAppTest.checkTi
metableTabs_compare.
png
KaigiAppTest.checkNa
vigateToBookmarkShot
_compare.png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_L
anguage_TimetableLis
tItemPreview-English
-12_15_null_compare.
png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_PreviewTimetabl
eGridItem-LightMode-
12_12_null_0_compare
.png
![](https://github.com/DroidKaigi/conference-app-2023/blob/companion_use-compose-bom/./screenshot-di

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 14, 2023 18:03 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 15, 2023 07:26 Inactive
@takahirom
Copy link
Member

Maybe the font is changed. Do you know which font is the right font?

@takahirom
Copy link
Member

Well, maybe the font is the same but the space of the text is changed?

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for aligning dependencies! This is what we need!

@takahirom takahirom merged commit a1e2d39 into DroidKaigi:main Sep 16, 2023
8 checks passed
@takahirom takahirom mentioned this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants