Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compose bom version 2023.09.00 #1215

Merged
merged 7 commits into from
Sep 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ class AndroidComposePlugin : Plugin<Project> {
}
}
dependencies {
implementation(platform(libs.library("composeBom")))
implementation(libs.library("androidxCoreKtx"))
implementation(libs.library("composeUi"))
implementation(libs.library("composeMaterial"))
implementation(libs.library("composeMaterial3"))
implementation(libs.library("composeUiToolingPreview"))
implementation(libs.library("androidxLifecycleLifecycleRuntimeKtx"))
implementation(libs.library("androidxActivityActivityCompose"))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
package io.github.droidkaigi.confsched2023.primitive

import org.gradle.api.Project
import org.gradle.api.artifacts.Dependency
import org.gradle.api.artifacts.MinimalExternalModuleDependency
import org.gradle.api.plugins.JavaPluginExtension
import org.gradle.api.provider.Provider
import org.gradle.kotlin.dsl.DependencyHandlerScope
import org.gradle.kotlin.dsl.configure

fun DependencyHandlerScope.implementation(
artifact: Dependency,
) {
add("implementation", artifact)
}

fun DependencyHandlerScope.implementation(
artifact: MinimalExternalModuleDependency,
) {
Expand Down
1 change: 1 addition & 0 deletions core/model/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ kotlin {
}

dependencies {
implementation(platform(libs.composeBom))
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.github.droidkaigi.confsched2023.floormap

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.BoxWithConstraints
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Row
Expand Down Expand Up @@ -203,9 +202,7 @@ private fun FloorMapContent(
end = contentPadding.calculateEndPadding(layoutDirection) + 16.dp,
bottom = contentPadding.calculateBottomPadding(),
)
BoxWithConstraints(
Modifier,
) {
Box {
if (widthSizeClass != WindowWidthSizeClass.Compact) {
LargeScreenContent(
uiState = uiState.largeFloorMapContentUiState,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,10 @@ fun PreviewTimetableScreenDark() {
mapOf<String, List<TimetableItem>>().toPersistentMap(),
Timetable(),
),
DroidKaigi2023Day.Day2 to TimetableListUiState(
mapOf<String, List<TimetableItem>>().toPersistentMap(),
Timetable(),
),
),
),
timetableUiType = TimetableUiType.Grid,
Expand Down
31 changes: 18 additions & 13 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ kotlin = "1.9.0"

androidxCore = "1.10.1"
androidDesugarJdkLibs = "2.0.3"
compose = "1.5.1"
compose-jb = "1.5.0"
compose = "2023.09.00"
composeCompiler = "1.5.2"
composeJb = "1.5.0"
composeMaterial3 = "1.2.0-alpha07"
composeHiltNavigatiaon = "1.0.0"
androidxLifecycle = "2.6.2"
androidxActivity = "1.8.0-beta01"
Expand Down Expand Up @@ -44,7 +45,7 @@ androidxLifecycleProcess = "2.6.2"
[libraries]
androidGradlePlugin = { group = "com.android.tools.build", name = "gradle", version.ref = "androidGradlePlugin" }
kotlinGradlePlugin = { group = "org.jetbrains.kotlin", name = "kotlin-gradle-plugin", version.ref = "kotlin" }
composeJbGradlePlugin = { group = "org.jetbrains.compose", name = "compose-gradle-plugin", version.ref = "compose-jb" }
composeJbGradlePlugin = { group = "org.jetbrains.compose", name = "compose-gradle-plugin", version.ref = "composeJb" }
hiltGradlePlugin = { group = "com.google.dagger", name = "hilt-android-gradle-plugin", version.ref = "dagger" }
roborazziGradlePlugin = { group = "io.github.takahirom.roborazzi", name = "roborazzi-gradle-plugin", version.ref = "roborazzi" }
kspGradlePlugin = { module = "com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin", version.ref = "ksp" }
Expand Down Expand Up @@ -79,17 +80,21 @@ kotlinxAtomicfu = { module = "org.jetbrains.kotlinx:atomicfu", version = "0.22.0

# UI

composeCompiler = { module = "androidx.compose.compiler:compiler", version.ref = "composeCompiler" }
composeUi = { module = "androidx.compose.ui:ui", version.ref = "compose" }
composeBom = { module = "androidx.compose:compose-bom", version.ref = "compose" }
composeRuntime = { module = "androidx.compose.runtime:runtime" }
composeUi = { module = "androidx.compose.ui:ui" }
composeUiUtil = { module = "androidx.compose.ui:ui-util" }
composeUiTooling = { module = "androidx.compose.ui:ui-tooling" }
composeUiToolingPreview = { module = "androidx.compose.ui:ui-tooling-preview" }
composeAnimation = { module = "androidx.compose.animation:animation" }
composeAnimationGraphics = { module = "androidx.compose.animation:animation-graphics" }
composeMaterial = { module = "androidx.compose.material:material" }
composeMaterial3 = { module = "androidx.compose.material3:material3", version.ref = "composeMaterial3" }
composeMaterialWindowSize = { module = "androidx.compose.material3:material3-window-size-class", version.ref = "composeMaterial3" }
composeMaterialIcon = { module = "androidx.compose.material:material-icons-extended" }
composeUiTestManifest = { module = "androidx.compose.ui:ui-test-manifest" }
composeUiTestJunit4 = { module = "androidx.compose.ui:ui-test-junit4" }
composeNavigation = { module = "androidx.navigation:navigation-compose", version = "2.7.2" }
composeRuntime = { module = "androidx.compose.runtime:runtime", version.ref = "compose" }
composeMaterial = { module = "androidx.compose.material3:material3", version = "1.1.1" }
composeMaterialWindowSize = { module = "androidx.compose.material3:material3-window-size-class", version = "1.1.1" }
composeMaterialIcon = { module = "androidx.compose.material:material-icons-extended", version = "1.5.1" }
composeUiToolingPreview = { module = "androidx.compose.ui:ui-tooling-preview", version.ref = "compose" }
composeUiTestJunit4 = { module = "androidx.compose.ui:ui-test-junit4", version.ref = "compose" }
composeUiTooling = { module = "androidx.compose.ui:ui-tooling", version.ref = "compose" }
composeUiTestManifest = { module = "androidx.compose.ui:ui-test-manifest", version.ref = "compose" }
composeHiltNavigtation = { module = "androidx.hilt:hilt-navigation-compose", version.ref = "composeHiltNavigatiaon" }
composeLintCheck = { module = "com.slack.lint.compose:compose-lint-checks", version = "1.2.0" }
composeCoil = { module = "io.coil-kt:coil-compose", version = "2.4.0" }
Expand Down
Loading