Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat control improvements #240

Merged
merged 16 commits into from
Oct 28, 2023
Merged

Feat control improvements #240

merged 16 commits into from
Oct 28, 2023

Conversation

jmccreight
Copy link
Member

@jmccreight jmccreight commented Sep 29, 2023 •
edited
Loading

@jmccreight
Control refactor:
8f04587 
1. warn of unused PRMS legacy options
2. translate PRMS legacy options to PWS options in clear way, documentation WIP on that
3. #2 includes outputting the variables requuested in the PRMS control file
@jmccreight
catch up notebooks to control options changes and warnings
558c995
@jmccreight
Control: 1) copy and deepcopy methods, 2) __setitem__ and __setattr__…
59685fe 
… for managing options attribute/item that enforces valid options, 3) control.options as an OptsDict which also enforces valid keys, 4) tests for the previous
@jmccreight
lint
b58484d
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #240 (a938fa4) into develop (3038a5b) will increase coverage by 0.09%.
The diff coverage is 84.12%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #240      +/-   ##
===========================================
+ Coverage    78.13%   78.22%   +0.09%     
===========================================
  Files           51       51              
  Lines         6563     6706     +143     
===========================================
+ Hits          5128     5246     +118     
- Misses        1435     1460      +25
Files Coverage Δ
pywatershed/atmosphere/prms_atmosphere.py 89.87% <100.00%> (+0.88%) ⬆️
pywatershed/atmosphere/prms_solar_geometry.py 91.70% <100.00%> (+0.98%) ⬆️
pywatershed/hydrology/prms_runoff.py 82.55% <100.00%> (-0.05%) ⬇️
pywatershed/hydrology/prms_snow.py 81.18% <100.00%> (+0.14%) ⬆️
pywatershed/utils/path.py 88.88% <100.00%> (+7.07%) ⬆️
pywatershed/utils/prms_to_mf6.py 87.89% <100.00%> (ø)
pywatershed/utils/utils.py 33.33% <100.00%> (+6.06%) ⬆️
pywatershed/base/process.py 87.71% <0.00%> (ø)
pywatershed/hydrology/prms_channel.py 92.34% <80.00%> (-1.38%) ⬇️
pywatershed/base/model.py 95.54% <94.33%> (+0.67%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmccreight jmccreight merged commit 5456603 into EC-USGS:develop Oct 28, 2023
10 checks passed
@jmccreight jmccreight mentioned this pull request Oct 28, 2023
Closed
@jmccreight jmccreight deleted the feat_control_improvements branch November 18, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control object features Limit variables written to NetCDF output.
2 participants
@jmccreight @codecov-commenter