Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat control improvements #240

Merged
merged 16 commits into from
Oct 28, 2023
Merged

Feat control improvements #240

merged 16 commits into from
Oct 28, 2023

Commits on Sep 28, 2023

  1. Control refactor: 

    1. warn of unused PRMS legacy options
2. translate PRMS legacy options to PWS options in clear way, documentation WIP on that
3. #2 includes outputting the variables requuested in the PRMS control file
    @jmccreight
    jmccreight committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8f04587 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. catch up notebooks to control options changes and warnings

    @jmccreight
    jmccreight committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    558c995 View commit details
    Browse the repository at this point in the history

  2. Control: 1) copy and deepcopy methods, 2) __setitem__ and __setattr__… 

    … for managing options attribute/item that enforces valid options, 3) control.options as an OptsDict which also enforces valid keys, 4) tests for the previous
    @jmccreight
    jmccreight committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    59685fe View commit details
    Browse the repository at this point in the history

  3. lint

    @jmccreight
    jmccreight committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b58484d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Control .to_yaml and .to_dict methods

    @jmccreight
    jmccreight committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    554899c View commit details
    Browse the repository at this point in the history

  2. merge upstream/develop

    @jmccreight
    jmccreight committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    70e3a51 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. remove dprst_flag from pws control options

    @jmccreight
    jmccreight committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    33a82f6 View commit details
    Browse the repository at this point in the history

  2. document pws and prms-legacy options for Control.options

    @jmccreight
    jmccreight committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    feb7a8c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. remove unused control options; model can optionally save the used con… 

    …trol object to file
    @jmccreight
    jmccreight committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    75aabd3 View commit details
    Browse the repository at this point in the history

  2. merge upstream

    @jmccreight
    jmccreight committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1ee3e88 View commit details
    Browse the repository at this point in the history

  3. clean up divide by zero in prms_to_mf6 test

    @jmccreight
    jmccreight committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9df0c95 View commit details
    Browse the repository at this point in the history

  4. options for soilzone and snow on parameter adjustment behavior: "warn… 

    …", "error", "no"
    @jmccreight
    jmccreight committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    633761c View commit details
    Browse the repository at this point in the history

  5. fix attribute adjust_parameters to private

    @jmccreight
    jmccreight committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ef355fe View commit details
    Browse the repository at this point in the history

  6. output file name formatting problem with windows

    @jmccreight
    jmccreight committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0560155 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. catch notebooks up with changes

    @jmccreight
    jmccreight committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    50b9778 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. cleanup minor issues w notebooks

    @jmccreight
    jmccreight committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a938fa4 View commit details
    Browse the repository at this point in the history