Use new stair-case approximation in hybrid solver #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to move_stair_case_approx
This reverts commit 4fd4dc7.
RemiLehe
changed the title
edge_lengths and face_areas anymore
RemiLehe
changed the title
RemiLehe
added a commit
that referenced
this pull request
Jan 21, 2025
When updating `E` (and when initializing the field values for `E` and `B` with a parser), we used to check somewhat complicated conditions that relied on the MultiFabs `edge_lengths` and `face_areas`. This PR introduces separate arrays (`m_eb_update_E` and `m_eb_update_B`, which are `iMultiFab` instead of `MultiFab` and thus take up much less memory). These arrays contain flags that keep track of where to udpate the fields (i.e. the black crosses in the above figure). These arrays are initialized in separate functions which keep the same EB definition. (PR #5534 will then change this definition.) The code for the field pusher and field initialization uses these arrays (instead of edge_lengths and face_areas. It is thus significantly simpler and avoids duplicating complicated if conditions. The above changes have not yet been implemented for the hybrid solver. This will instead be done in a separate PR: #5558. Once this is complete, the MultiFab `edge_lengths` and `face_areas` will not be needed anymore (except for the ECT solver), and we will thus only allocate them for the ECT solver. This should save a significant amount of memory. --------- Co-authored-by: Roelof Groenewald <[email protected]>
There was a problem hiding this comment.
This looks good. I'll just give it a final look through once #5534 is merged and any conflicts are resolved before approving.
Co-authored-by: Roelof Groenewald <[email protected]>
for more information, see https://pre-commit.ci
roelof-groenewald
requested changes
Jan 21, 2025
Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceSolver.H
Outdated
Show resolved
Hide resolved
Source/FieldSolver/FiniteDifferenceSolver/FiniteDifferenceSolver.H
Outdated
Show resolved
Hide resolved
Source/WarpX.H
Outdated
| @@ -927,8 +927,7 @@ public: | |||
| * \param[in] fx_parser parser function to initialize x-field | |||
| * \param[in] fy_parser parser function to initialize y-field | |||
| * \param[in] fz_parser parser function to initialize z-field | |||
| * \param[in] edge_lengths edge lengths information | |||
| * \param[in] face_areas face areas information | |||
| * \param[in] eb_update_field flag indicating which gridpoints should be modified by this functions | |||
There was a problem hiding this comment.
The topology parameter description below this line can be removed.
RemiLehe
changed the title
Co-authored-by: Roelof Groenewald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #5534 first.
This extends the changes of #5534 and #5574 to the hybrid solver.
Note that this effectively changes the definition of the stair-cased embedded boundary for the hybrid solver.