Add product tag plugin #87
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdlcf88
reviewed
Aug 21, 2020
| { | ||
| public class GetTagListDto : PagedAndSortedResultRequestDto, IMultiStore | ||
| { | ||
| [Required] |
There was a problem hiding this comment.
The [Required] can be removed since the type Guid is not nullable.
|
|
||
| public Guid? ParentId { get; set; } | ||
|
|
||
| public string Code { get; set; } |
There was a problem hiding this comment.
If there are many stores, what if the total number of Tag in all stores is more than 99999?
| { | ||
| await CheckGetListPolicyAsync(); | ||
|
|
||
| await AuthorizationService.CheckStoreOwnerAsync(input.StoreId, GetListPolicyName); |
There was a problem hiding this comment.
Please refer to the reviews in #81
|
|
||
| query = query.Where(x => x.StoreId == input.StoreId); | ||
|
|
||
| return input.ShowHidden ? query : query.Where(x => !x.IsHidden); |
There was a problem hiding this comment.
Maybe a manage permission for checking if a user can see the hidden items?
| { | ||
| } | ||
|
|
||
| public async Task<List<Tag>> GetListByAsync(Guid storeId, bool includeDetails = false, CancellationToken cancellationToken = default) |
| <PackageReference Include="Volo.Abp.Ddd.Application" Version="3.0.5" /> | ||
| <ProjectReference Include="..\..\..\..\modules\EasyAbp.EShop.Products\src\EasyAbp.EShop.Products.Application.Contracts\EasyAbp.EShop.Products.Application.Contracts.csproj" /> | ||
| <ProjectReference Include="..\..\..\..\modules\EasyAbp.EShop.Products\src\EasyAbp.EShop.Products.Domain\EasyAbp.EShop.Products.Domain.csproj" /> | ||
| <ProjectReference Include="..\..\..\..\modules\EasyAbp.EShop.Stores\src\EasyAbp.EShop.Stores.Application\EasyAbp.EShop.Stores.Application.csproj" /> |
There was a problem hiding this comment.
It should not depend on the Stores.Application module.
Comment on lines
+38
to
+41
| <ItemGroup> | ||
| <None Remove="Pages\EShop\Products\Tags\Tag\index.css" /> | ||
| <None Remove="Pages\EShop\Products\Tags\Tag\index.js" /> | ||
| </ItemGroup> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add product tag plugin, replace #67