Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round 3 of workflow refactoring #59

Merged
merged 45 commits into from
Sep 25, 2024
Merged

Round 3 of workflow refactoring #59

merged 45 commits into from
Sep 25, 2024

Conversation

typotter
Copy link
Collaborator

@typotter typotter commented Aug 29, 2024

🎟️ Fixes FF-3097 towards FF-3085

👯‍♂️ Related PRs

Motivation

Changes are often made to the sdk-test-data repository to capture new behaviours, bugs and edge cases. When these changes are pushed to main, the SDKs are cloned locally (locally to the github action running) and their respective tests are run. These tests are set up and run by copies of the SDK test workflows - see sdk-test-data workflow. There are a number of limitations to this setup:

  • Test steps are copied from the SDK’s respective workflows; changes to the SDK test workflows need to be replicated in sdk-test-data and this is not obvious to devs
  • The SDK tests are not able to run against in-flight changes to sdk-test-data
  • When new test-data is committed that breaks an SDK, that breakage is not surfaced in the SDK’s repository until some action triggers its testing workflow (on demand, on pull-request, etc.).

Description of Changes

  • Refactor testig for SDKs: react-native, golang, ios, ruby, android

Repos are green!
Screenshot 2024-08-29 at 10 13 05 AM

External to this Change
🚀 - Each SDK's testing workflow is enhanced into a reusable workflow, exposing parameters for SDK branch and the sdk-test-data branch to use in testing.

@typotter typotter force-pushed the tp/workflows/round3 branch from 48d9e86 to c3c3b0a Compare August 29, 2024 05:10
@typotter typotter changed the title Tp/workflows/round3 Round 3 of workflow refactoring Aug 29, 2024
Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (assuming we replace the personal branch with the main ones once they are emerged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants