-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Xcode 16 minimum #883
Draft
dfeinzimer
wants to merge
38
commits into
v.next
Choose a base branch
from
df/Xcode16
base: v.next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 25 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
c409e59
Bump `LastUpgradeVersion`
dfeinzimer deaaba5
Bump swift-tools-version
dfeinzimer 3b476ef
Add SWIFT_VERSION to "Examples" project
dfeinzimer 6c4a6af
Bump SWIFT_VERSION to 6.0 for Toolkit Examples target
dfeinzimer ba11e27
Specify Swift 6 for Authentication project and target
dfeinzimer b94cece
Specify Swift 6 for Job Manager project and target
dfeinzimer 374baf2
Specify Swift 6 for Test Runner project and targets
dfeinzimer 24f41de
Bump LastUpgradeVersion in other schemes
dfeinzimer 5aca095
Update FlyoverExampleView.swift
dfeinzimer 35a7c59
Fix error in `UtilityNetworkTraceViewModel.addStartingPoints(at:mapPo…
dfeinzimer 05b4c65
Fix error in `AttachmentCameraController.onCameraCaptureModeChanged(p…
dfeinzimer 3401c02
Fix error in `AttachmentCameraController.onCameraCaptureModeChanged(p…
dfeinzimer 89c22a0
Remove experimental and upcoming feature flags
dfeinzimer aae526d
Add missing default case to `TextFormElementView`
dfeinzimer 317758b
Bump `objectVersion` to `77`
dfeinzimer 689075e
Bump `LastUpgradeCheck` to `1600`
dfeinzimer d5b28a4
Update FlyoverExampleView.swift
dfeinzimer b7414cc
Update TableTopExampleView.swift
dfeinzimer f13fa49
Update GroupView.swift
dfeinzimer 10be361
Update HTMLTextView.swift
dfeinzimer edaa5cd
Fix `SearchSource` sendability errors
dfeinzimer abc22c4
Update ExampleView.swift
dfeinzimer ea5f86f
Update AnyExample.swift
dfeinzimer 0d726f1
Drop `MainActor.runUnsafely`
dfeinzimer cb31175
Update ValueContinuation.swift
dfeinzimer 1eba326
Drop older Xcode `compatibilityVersion`s
dfeinzimer 9f22362
Add Xcode 16 `preferredProjectObjectVersion`
dfeinzimer aa4eded
Update LoginViewModifierTests.swift
dfeinzimer 51f2f05
Update RepresentedUITextViewTests.swift
dfeinzimer 88ce733
Update FormViewTests.swift
dfeinzimer 5495f9a
Update FloorFilterTests.swift
dfeinzimer 203dc65
Update BookmarksTests.swift
dfeinzimer 24c7c12
Update BasemapGalleryTests.swift
dfeinzimer 47aa4f7
Update AttachmentCameraControllerTests.swift
dfeinzimer 47794ce
Merge branch 'v.next' into pr/883
dfeinzimer c90e603
Revert "Add missing default case to `TextFormElementView`"
dfeinzimer 399a495
Update TableTopSceneView.swift
dfeinzimer a1d6d68
Merge branch 'v.next' into pr/883
dfeinzimer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
.swiftpm/xcode/xcshareddata/xcschemes/arcgis-runtime-toolkit-swift.xcscheme
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
Examples/Examples.xcodeproj/xcshareddata/xcschemes/Toolkit Examples.xcscheme
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...agerExample/JobManagerExample.xcodeproj/xcshareddata/xcschemes/JobManagerExample.xcscheme
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adopting the
Sendable
protocol is easy, doing so right can be hard. Neither of the conforming types are actually sendable nor would it be easy to make them so. That is why I didn't do this myself when enabling complete strict concurrency. We may end up having no other choice, but if so, we should make an effort to make the conforming types thread safe, as difficult as that will be. The best option is probably to re-design the API, but I don't think we want to do that right now.