Migrate to Xcode 16 minimum #883
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int:with:)` Fixes error: Main actor-isolated value of type '() async -> Void' passed as a strongly transferred parameter; later accesses could race
…erform:)` Fixes error: Main actor-isolated property 'microphoneAccessAlertIsVisible' can not be mutated from a Sendable closure
…erform:)` Fixes error: Assigning non-sendable parameter 'action' to a @sendable closure
Main actor-isolated value of type '() async throws -> ()' passed as a strongly transferred parameter; later accesses could race
Main actor-isolated value of type '() async throws -> ()' passed as a strongly transferred parameter; later accesses could race
Main actor-isolated value of type '() async -> ()' passed as a strongly transferred parameter; later accesses could race
Main actor-isolated value of type '() async -> ()' passed as a strongly transferred parameter; later accesses could race
Fixes "Sending 'source' risks causing data races" at https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/blob/b322842cf427b4c8d59b00768af7d9b8c75ad1f1/Sources/ArcGISToolkit/Components/Search/SearchViewModel.swift#L256 and https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/blob/b322842cf427b4c8d59b00768af7d9b8c75ad1f1/Sources/ArcGISToolkit/Components/Search/SearchViewModel.swift#L270 and https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/blob/b322842cf427b4c8d59b00768af7d9b8c75ad1f1/Sources/ArcGISToolkit/Components/Search/SearchViewModel.swift#L285
Property was unused and Main actor-isolated property 'id' cannot be used to satisfy nonisolated protocol requirement
Fixes various instances of "Call to main actor-isolated initializer 'init()' in a synchronous nonisolated context" in Examples.swift
Fixes "Sending 'self' risks causing data races" @ ARSwiftUIView.swift line 153
Sending 'value' risks causing data races
philium
reviewed
Sep 24, 2024
| @@ -15,7 +15,7 @@ | |||
| import ArcGIS | |||
|
|
|||
| /// Defines the contract for a search result provider. | |||
| public protocol SearchSource { | |||
| public protocol SearchSource: Sendable { | |||
There was a problem hiding this comment.
While adopting the Sendable protocol is easy, doing so right can be hard. Neither of the conforming types are actually sendable nor would it be easy to make them so. That is why I didn't do this myself when enabling complete strict concurrency. We may end up having no other choice, but if so, we should make an effort to make the conforming types thread safe, as difficult as that will be. The best option is probably to re-design the API, but I don't think we want to do that right now.
This reverts commit aae526d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Verified all example projects build okay
✅ Verified tests
✅ Verified affected component behavior
To Do: