-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEXQonfig: Allow system-provided RootFS images #4067
FEXQonfig: Allow system-provided RootFS images #4067
Conversation
Add a secondary RootFS directory that can be managed by the system package manager.
Could you explain a bit on the background for this? For Asahi specifically, the system rootfs will end up living in /run/share/fex-emu, I think, due to krun magic. |
For gentoo, i do not want to do krun magic inside the vm, and instead create the squashfs and overlay mounts on the host. Since mounting it inside the per-user rootfs directory would be quite annoying to implement, I instead want to add a secondary "default" rootfs search directory. |
And while the current gentoo work is asahi-specific, i want to also run it on my rk3588 boards, which will not use krun. |
OK, makes sense. Not too different from the fedora asahi use case then.. |
Global rootfs doesn't support a named rootfs (only local supports that). So when it is a global rootfs option just give the full path to the config path. Just needs some special handling to ensure the full path is retained for global paths. A reimplementation of FEX-Emu#4067 that doesn't hardcode paths and routes the global data path through FEXCore.
Global rootfs doesn't support a named rootfs (only local supports that). So when it is a global rootfs option just give the full path to the config path. Just needs some special handling to ensure the full path is retained for global paths. A reimplementation of FEX-Emu#4067 that doesn't hardcode paths and routes the global data path through FEXCore.
I had a couple of concerns that I didn't have time to articulate before today. So I spent a bit of time to implement this closer to what FEX would want.
Thank you for bringing up that you wanted this as a feature in FEXConfig! |
Global rootfs doesn't support a named rootfs (only local supports that). So when it is a global rootfs option just give the full path to the config path. Just needs some special handling to ensure the full path is retained for global paths. A reimplementation of FEX-Emu#4067 that doesn't hardcode paths and routes the global data path through FEXCore.
Handled by #4074. If there's any more features you want then make sure to let us know. |
Add a secondary RootFS directory that can be managed by the system package manager.