FEXConfig: Add the ability to watch and configure global rootfs #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
global_rootfs
branch
from
67fcb37
to
1f41516
Compare
Currently unused as all data still comes from local installs.
Using select initially was a mistake, it has issues with FD limits and is less efficient due to fd_set. It's recommended to switch select using over to polling, so do it.
Global rootfs doesn't support a named rootfs (only local supports that). So when it is a global rootfs option just give the full path to the config path. Just needs some special handling to ensure the full path is retained for global paths. A reimplementation of FEX-Emu#4067 that doesn't hardcode paths and routes the global data path through FEXCore.
Sonicadvance1
force-pushed
the
global_rootfs
branch
from
1f41516
to
77b801b
Compare
|
Rebased and merge conflict fixed. |
neobrain
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global rootfs doesn't support a named rootfs (only local supports that).
So when it is a global rootfs option just give the full path to the
config path.
Just needs some special handling to ensure the full path is retained for
global paths.
A reimplementation of #4067 that doesn't hardcode paths and routes the
global data path through FEXCore.