Add HEAD.NOTE to many example files #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in FamilySearch/GEDCOM#561 many of the example files don't make any sense: they contain more-or-less random payloads of the right type for each structure. This adds the following to the header of each such file: ```ged 1 NOTE This file is intended to provide coverage of parts of the specification and does not contain meaningful historical or genealogical data. ``` Note that some example files are made-up data but at lease somewhat internally consistent; for example, `same-sex-marriage.ged` has internally-consistent (but made-up) names and relationships. This does not add that note to those files. This commit also does not change the .gdz files. I can't recall if those are automatically updated or if I need to update them manually.
tychonievich
requested review from
clarkegj,
dthaler and
lynchrs3
as code owners
You need to update it manually. Can you add it to this PR? |
Closed
|
Approved during GEDCOM Steering Committee meeting |
dthaler
pushed a commit
to dthaler/GEDCOM.io
that referenced
this pull request
Nov 5, 2024
From PR FamilySearch#206 Fixes FamilySearch#209 Signed-off-by: Dave Thaler <[email protected]>
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in FamilySearch/GEDCOM#561 many of the example files don't make any sense: they contain more-or-less random payloads of the right type for each structure. This adds the following to the header of each such file:
Note that some example files are made-up data but at lease somewhat internally consistent; for example,
same-sex-marriage.gedhas internally-consistent (but made-up) names and relationships. This does not add that note to those files.This commit also does not change the .gdz files. I can't recall if those are automatically updated or if I need to update them manually.