Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to properly work and highlight #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

camila314
Copy link

Didn't work for me originally but these changes fixed for me

@jrappen
Copy link

jrappen commented Mar 7, 2025

Could you also fix to require basename.startswith("syntax_test_") (with trailing _) while at it for file name a few lines down?

@FichteFoll
Copy link
Owner

Thanks for the changes. We will have to either make this change conditional based on which ST build we're running on, or I will have to make a new release channel for ST builds above the first version that changed the output format. Since this package hasn't needed updates in the past 6 years, I currently prefer the latter.

I will take a closer look and pepare a new release when I find the time.

@kaste
Copy link
Contributor

kaste commented Mar 7, 2025

I've prepared a PR at SL's package control to freeze a ST3 version. You just need to make and push a tag st3-1.1.2 pointing to the current v1.1.2. After that I could merge, the PR; if I merge before the tag, PC marks this plugin as invalid or missing IIRC.

Finally, you could then add a .python-version file here to lift the plugin to Python 3.8, and use the walrus ( elif car := carats.search(m.message):) here in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants