Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up newer version of SublimeLinter-contrib-sublime-syntax #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaste
Copy link
Contributor

@kaste kaste commented Mar 7, 2025

Copy link

@FichteFoll FichteFoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for already going ahead with the changes. I'll let you know when you can merge them.

Comment on lines +1491 to 1496
"sublime_text": "3092 - 4180",
"tags": "st3-"
},
{
"sublime_text": ">=4181",
"tags": true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"sublime_text": "3092 - 4180",
"tags": "st3-"
},
{
"sublime_text": ">=4181",
"tags": true
"sublime_text": "3092 - 4180",
"tags": "3092-"
},
{
"sublime_text": ">=4181",
"tags": "4181-"

I'll likely stick to this strategy that I adoped from deathaxe that more clearly communicates which build a version starts being used for, which is becoming more and more likely to occur since ST moved away from selling major version updates only and especially with regards to syntax packages depending on built-in syntaxes (not relevant here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make your life easier with true for the current/recent cycle, and only mark/freeze a specific version. That way the tags read natural and look semantic. 🤷‍♀️ It is still possible that such frozen tags are more and more likely in the future, but also that a future PC will allow us to declare tags: "=1.2.0". 🤷‍♂️ But just tell me when you're done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants