fix: Allow creating shelf files again #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with these things, I have never used that shelv thing, so if it work for you I am fine with merging it |
AiyionPrime
force-pushed
the
fix/creating_shelf_files
branch
2 times, most recently
from
8c2a3d4 to
9283b37
Compare
AiyionPrime
commented
Feb 16, 2024
| @@ -187,9 +187,6 @@ def test_sync_server_get_node(server, idx): | |||
| assert vars[0].read_value() == 6.7 | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail( | |||
| raises=AttributeError, reason="asyncua introduced a regression, likely when we switched to pathlib", strict=True | |||
There was a problem hiding this comment.
Now this strict=True would have led your pipeline to fail, if I resolved the issue, without removing this xfail marker again.
All in all this is a rather clean structure for test driven development with pytest, which I've learned to value over time.
to clarify its intended usage.
in internal_server and address_space. Path.is_file does not consume strings, as shelf.open does only consume string and not pathlib.Path.
|
@oroulet all tests passed, this also is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.