Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personal Space log tweak [bounty: 2 XTR] #2198

Closed
DreadKnight opened this issue Apr 11, 2023 · 2 comments
Closed

Personal Space log tweak [bounty: 2 XTR] #2198

DreadKnight opened this issue Apr 11, 2023 · 2 comments
Labels
abilities The issue is related to an unit ability or more bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer visuals Various things that easily catch the eye
Milestone
0.5 - Chimera

Comments

@DreadKnight
Copy link
Member

Following PR #2149:

  • passive should only trigger a message log if enemy in personal space, without the "enemy in" or "no one" extra stuff, as we're trying to keep those logs small; will probably increase the box soon to make this an one liner & some others
@DreadKnight DreadKnight added coding This issue requires some programming visuals Various things that easily catch the eye abilities The issue is related to an unit ability or more bounty Some amount of our token, XatteR, is offered labels Apr 11, 2023
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone Apr 11, 2023
This was referenced Apr 11, 2023
Merged
Open
@DreadKnight DreadKnight added the easy Good place to start if you're a new developer label Jul 26, 2023
@JoelFernandes09
Copy link
Contributor

#2396 fixes this issue to an extent so the ability is only triggered when an enemy is in range, do we wanna make the text changes & remove the "Enemy in" as well? So the final statement would be "Bounty Hunter is affected by Personal Space". (This also takes up 2 lines in the logs similar to having 'enemy in')

@DreadKnight

@DreadKnight
Copy link
Member Author

@JoelFernandes09 I noticed it was fixed overall. Guess we can leave it like this (for now at least) as it doesn't trigger pointlessly anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abilities The issue is related to an unit ability or more bounty Some amount of our token, XatteR, is offered coding This issue requires some programming easy Good place to start if you're a new developer visuals Various things that easily catch the eye
Projects
None yet
Milestone
0.5 - Chimera
Development

No branches or pull requests
2 participants
@DreadKnight @JoelFernandes09