Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudfront Provider; use of node-fetch #1641

Closed
RobAndrewHurst opened this issue Oct 31, 2024 · 1 comment · Fixed by #1645
Closed

Cloudfront Provider; use of node-fetch #1641

RobAndrewHurst opened this issue Oct 31, 2024 · 1 comment · Fixed by #1645
Assignees
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance.

Comments

@RobAndrewHurst
Copy link
Contributor

Description

There is old legacy code in the cloudfront provider that is using the (node-fetch) package that was phased out over 2 years a go.
We noticed it would break after removing bcrypt as a dependency for the application.

--Before--

const nodeFetch = require('node-fetch')
const response = await nodeFetch(signedURL)

--After--

const response = await fetch(signedURL)

We need to remove the require statement from the module & change the fetch reference in the code.

  • ✅ Bug
@RobAndrewHurst RobAndrewHurst added Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance. labels Oct 31, 2024
@RobAndrewHurst RobAndrewHurst self-assigned this Oct 31, 2024
@dbauszus-glx dbauszus-glx changed the title Remove (node-fetch) Cloudfront Signer and Provider; use of node-fetch Oct 31, 2024
@dbauszus-glx
Copy link
Member

There are other issues with the cloudfront module as commented in the PR. Should these be addressed in this PR or do you want to create a separate issue for the Error handling?

@dbauszus-glx dbauszus-glx changed the title Cloudfront Signer and Provider; use of node-fetch Cloudfront Provider; use of node-fetch Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Code Issues related to the code structure and performance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants