-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy node-fetch and document mod/cloudfront ☁️ #1645
Conversation
I still want to test this failing. I think the try...fetch is just there to throw an error if the key is undefined or fails to sign. I want to actually test this providing a false key and a false resource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1542 must be merged into this PR.
The provider module must return an Error rather than text failed to retrieve resource.
The cloudfront module must export null if the cloudfront key is not defined rather than throwing an Error which isn't caught.
The cloudfront module must return an Error and not just throw and Error with no return if the resource is not available or failed to resource.
The urlSigner should be a signer module to be imported by the provider module for internal use. signedUrl request should be rerouted to the cloudfront signer module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go. I create a seperate issue for the code structure and security concerns.
Quality Gate passedIssues Measures |
Description
I have removed the
node-fetch
reference in the cloudfront.js mod.I also added in documentation for the script.
GitHub Issue
#1641
Type of Change
Please delete options that are not relevant, and select all options that apply.
Code Quality Checklist