Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign params as URL paramstring to tile layer URI #1186

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

dbauszus-glx
Copy link
Member

The paramString util must return an empty string if provided with a falsy params argument.

The tile layer format should create a paramString to be appended to the layer.URI.

Params such as the api keys should be provided as params in the layer json. eg.

      "here_hybrid": {
        "name": "HERE Hybrid",
        "format": "tiles",
        "URI": "https://{1-4}.aerial.maps.ls.hereapi.com/maptile/2.1/maptile/newest/hybrid.day/{z}/{x}/{y}/256/png8?",
        "params": {
          "apiKey": "here"
        },
        "attribution": {
          "© Here": "https://www.here.com/",
          "© OpenStreetMap": "http://www.openstreetmap.org/copyright"
        }
      },

@dbauszus-glx dbauszus-glx added the Feature New feature requests or changes to the behaviour or look of existing application features. label Mar 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RobAndrewHurst
Copy link
Contributor

@dbauszus-glx
This then isn't backwards compatible with previous here configuration?

Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Looks all good to me!

Copy link
Contributor

@AlexanderGeere AlexanderGeere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with the params or the key in the URI. Looks good to me

@dbauszus-glx dbauszus-glx merged commit 8711e08 into GEOLYTIX:main Mar 19, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the url-tile-params branch June 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants