-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cloudinary provider module #1542
remove cloudinary provider module #1542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected.
I've replaced alerts and confirms with ui elements plus more human wording on removal confirm;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can't work with both images and documents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have have replaced the remove_item_confrim entry on the dictionary with two items. One for images and the other for documents.
They are then passed to the trash method as params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing tests for the module
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this!
The cloudinary provider module which requires the image/document payload to be passed through the xyz host has been removed.
The signer module has now been reviewed and documented.
The cloduinary signer module has now been reviewed and documented.
The module will not fail silently but return an error message.
The cloudinary entry is now using the cloudinary signer module.
The cloudinary entry is now reviewed and documented.
The cloudinary entry requires a cloudinary account. However, no third party module is required to sign requests, hence the cloudinary signer is included in the XYZ core and the cloudinary entry method is included in the mapp location entries.