-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog CSS/ Attribution link css: add z-index to dialogand remove from attribution links #1615
Dialog CSS/ Attribution link css: add z-index to dialogand remove from attribution links #1615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if this can be solved without magic numbers.
5 puts the dialog above the sliders as they max out at 4 |
If god is 7 because the devil is 6, then that needs to be commented on because otherwise it is just a [magic] number. And of course this needs to go back to the source... Why is the devil 6? Is he dependent on someone else being 5? Perhaps man. At best it is confusing if z-indexes are defined accross the style sheets at worst there might be a cleaner solution which does not require the use of z-indexes in the first place. Perhaps the devil doesn't need to be 6. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have replace that z-index on the dialog with the css property isolation and giving it the value isolate which will create a new stack context on the dialog itself which will not create issues with other z-index's of other elements.
/* Keyword values */
isolation: auto;
isolation: isolate;
/* Global values */
isolation: inherit;
isolation: initial;
isolation: revert;
isolation: revert-layer;
isolation: unset;
We are going to want to use this to fix all of the z-index mess we have created in other styles :)
This has been fixed with the isolation property on the dialog
Description
Removed the z-index from the attribution-links class. Added a z-index of 5 to the dialog CSS.
The attribution links remain on top of everything, but dialogs can be moved over them.
GitHub Issue
#1614 and #1613
Type of Change
How have you tested this?
Tested locally on
/demo
or any instance with a dialog.Testing Checklist
Code Quality Checklist