Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog CSS/ Attribution link css: add z-index to dialogand remove from attribution links #1615

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,39 +16,39 @@ The executables `git` and `node` should be in your `PATH`.

To install the Node.js dependencies run

$ npm install
npm install

Please check the full list of dependencies as defined in the [package.json](https://github.com/GEOLYTIX/xyz/blob/main/package.json)

## ESBuild

The MAPP and MAPP.UI library must be build with [esbuild](https://esbuild.github.io/) prior to launching the host.

$ npx esbuild ./lib/mapp.mjs ./lib/ui.mjs --bundle --minify --tree-shaking=false --sourcemap --format=iife --outdir=./public/js/lib
npx esbuild ./lib/mapp.mjs ./lib/ui.mjs --bundle --minify --tree-shaking=false --sourcemap --format=iife --outdir=./public/js/lib

The build command is stored in the package.json as `_build` script.

$ npm run _build
npm run _build

ESBuild must also be used to compile the CSS supporting the MAPP and MAPP.UI elements.

$ npx esbuild --bundle public/css/_mapp.css --outfile=public/css/mapp.css
npx esbuild --bundle public/css/_mapp.css --outfile=public/css/mapp.css

$ npx esbuild --bundle public/css/_ui.css --outfile=public/css/ui.css --loader:.svg=dataurl
npx esbuild --bundle public/css/_ui.css --outfile=public/css/ui.css --loader:.svg=dataurl

## version.js hash

The mapp module object holds a hash of the latest release commit which can be generated by executing the version.js script in the root.

The version script will complete by executing the ESBuild process.

$ node version.js
node version.js

## Express

[Express.js](https://expressjs.com/) will be installed by npm as a development dependency. You can run a zero config instance by loading the express.js script in your node runtime.

$ node express.js
node express.js

The default port is 3000. You can access the mapp interface on <http://localhost:3000/> in your browser.

Expand Down
1 change: 1 addition & 0 deletions public/css/_dialog.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dialog.dialog {
user-select: none;
padding: 5px;
overflow: unset !important;
isolation: isolate;
}

dialog.modal {
Expand Down
17 changes: 9 additions & 8 deletions public/css/_inputs.css
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ input[type=search]+ul:active {

input[type="search"]::-webkit-search-cancel-button,
input[type="search"]::-webkit-search-decoration:hover,
input[type="search"]::-webkit-search-cancel-button:hover {
cursor:pointer;
input[type="search"]::-webkit-search-cancel-button:hover {
cursor: pointer;
}

label.checkbox {
Expand Down Expand Up @@ -243,9 +243,10 @@ label.checkbox {

&>.head>.icon {
content: url("../icons/icon-drop-up.svg");
}
}
}
&.dropdown-reverse > ul {

&.dropdown-reverse>ul {
bottom: 30px;
}
}
Expand Down Expand Up @@ -291,13 +292,13 @@ label.checkbox {
z-index: 2;
width: calc((var(--a) - var(--min)) / var(--dif) * (100% - 10px));
}

&.multi {
& >.label-row {
&>.label-row {
display: flex;
justify-content: space-between;

& >div {
&>div {
flex-grow: 1
}
}
Expand Down Expand Up @@ -384,4 +385,4 @@ label.checkbox {
background-repeat: no-repeat;
background-position: center;
box-shadow: none;
}
}
1 change: 0 additions & 1 deletion public/css/_mapp.css
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ a > img {
}

.attribution-links {
z-index: 999;
text-align: right;
font-size: 95%;

Expand Down
1 change: 0 additions & 1 deletion public/css/mapp.css
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ a > img {
user-select: none;
}
.attribution-links {
z-index: 999;
text-align: right;
font-size: 95%;
& a {
Expand Down
1 change: 1 addition & 0 deletions public/css/ui.css
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ dialog.dialog {
user-select: none;
padding: 5px;
overflow: unset !important;
isolation: isolate;
}
dialog.modal {
position: fixed;
Expand Down
Loading