Fix compilation issues and PVT Driver unit test on Pangea3 #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sframba
changed the title
dkachuma
approved these changes
Jan 4, 2024
TotoGaz
approved these changes
Jan 10, 2024
CusiniM
reviewed
Jan 12, 2024
| using ExecPolicy = typename FLUID_TYPE::exec_policy; | ||
| forAll< ExecPolicy >( composition.size( 0 ), | ||
| [this, numPhases, numComponents, numSteps, kernelWrapper, |
There was a problem hiding this comment.
ah yeah, capturing this by value won't work if run on device.
ouassimkh
pushed a commit
that referenced
this pull request
Feb 16, 2024
* removed access to private class members from device code * modified host config for P3 * removed CUDA Hypre flag (does not completely work on P3) * Re-enabled cuda acceleration for hypre --------- Co-authored-by: Matteo Cusini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GEOS is broken on Pangea3 due to a few issues with compilation and with the
PVTDrivermodule's tests.cudato version11.5on Pangea3. In particular,Hypre is by default compiled without CUDA acceleration (not completely supported);hypre with cuda acceleration seems to be mostly working nowcuda(solution suggested by @corbett5), andOverall, this PR restores compilation and functionality on Pangea3.
There is a companion thirdPartyLibs PR, #253, which updates and makes the host config files consistent.