Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Pangea3 host config with C++17 standard #253

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

sframba
Copy link
Contributor

@sframba sframba commented Dec 22, 2023

Companion PR to GEOS' PR #2910, this PR updates the Pangea 3 host config file after upgrade od cuda to version 11.5 on this machine. In particular,

  • The c++ standard is set to c++17 (as it should be for GEOS)
  • The default hypre implementation on the machine is set to CPU (GPU not supported for all applications) hypre with cuda acceleration seems to be mostly working now
  • A flag allowing host constexpr call form device code is added, reducing warnings
  • CUpti profiling via Caliper is enabled by default

@sframba sframba self-assigned this Dec 22, 2023
@sframba sframba added the bug Something isn't working label Dec 22, 2023
@sframba sframba requested a review from TotoGaz December 22, 2023 10:40
@victorapm
Copy link
Contributor

victorapm commented Dec 22, 2023

Hi Stefano, can you share which models don't work with hypre GPU?

@sframba
Copy link
Contributor Author

sframba commented Dec 26, 2023

Hi Stefano, can you share which models don't work with hypre GPU?

Hi @victorapm , this was the way we used to compile everything on Pangea 3 (Power9 CPUs with Nvidia V100+ nvcc 11.0.3), we had some issues with some solvers such as CompositionalMultiphaseFVM . We haven't tested with the latest versions of hypre. Let me put this on hold while I test the latest TPLs on Pangea3

@sframba
Copy link
Contributor Author

sframba commented Dec 26, 2023

Hi Stefano, can you share which models don't work with hypre GPU?

Hi again @victorapm, it seems that with the latest version of hypre, one of the GEOS unit tests still fails on Pangea3: testExternalSolvers, with only one test failing: Hypre/SolverTestLaplace2D/0.GMRES_ILU.
Still, the flow simulation that was holding us back seems to be working now, so I'll re-enable hypre cuda acceleration by default in this PR

@sframba sframba changed the title Updated Pangea3 host config with C++17 standard, default to CPU hypre implementation Updated Pangea3 host config with C++17 standard Dec 26, 2023
@victorapm
Copy link
Contributor

Thanks, Stefano! I will check with @castelletto1 about the failing test

@CusiniM CusiniM merged commit d674601 into master Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants