Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support Spack #28

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

mathomp4
Copy link
Member

This zero-diff PR has build system changes to support the use of Spack. Most of the changes just make the GEOS CMake look more like canonical CMake. GEOS previously couldn't support this, but it now can.

See GEOS-ESM/GEOSgcm#387 for overall issue.

NOTE: This PS only affects this old GEOS fork-branch of FMS. When GEOS moves to FMS as a Baselib, this is unneeded.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 10, 2022
@mathomp4 mathomp4 self-assigned this Mar 10, 2022
@mathomp4 mathomp4 marked this pull request as ready for review March 17, 2022 17:06
@mathomp4
Copy link
Member Author

Scott has pulled in GEOS-ESM/GEOSgcm#388. Therefore, I feel safe undrafting this.

@mathomp4 mathomp4 merged commit b81b084 into geos/release/2019.01 Mar 17, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/spack branch March 17, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant