Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GEOSgcm to support Spack #387

Open
8 of 17 tasks
mathomp4 opened this issue Mar 9, 2022 · 0 comments · Fixed by #394
Open
8 of 17 tasks

Update GEOSgcm to support Spack #387

mathomp4 opened this issue Mar 9, 2022 · 0 comments · Fixed by #394
Assignees
@mathomp4
Labels
enhancement New feature or request

Comments

@mathomp4
Copy link
Member

mathomp4 commented Mar 9, 2022 •
edited
Loading

In order to support Spack for building GEOS instead of Baselibs, we need to make some rather comprehensive changes to our repos. My current testing shows for GEOSgcm we need to update:

Most of these are under GMAO control. The next step in this is to test if we can "dribble in" these changes to not annoy @sdrabenh as much as I could. I have a plan of attack for this:

  • First we need to get in the ESMA_env and ESMA_cmake changes. Check for zero-diff with current GEOS.
  • Assuming that works, add in one of these, say, UMD_Etc, and make sure that doesn't fail.
  • Continue ad nauseum

Note on HEMCO: The weird one out is HEMCO as that is a fork maintained by @christophkeller. The fix above is based on what GEOS currently uses (geos/v2.2.3) but that is essentially a "dead branch" for HEMCO in GEOS. However, this fix also needs to be inserted into the correct development path that @christophkeller is working on. I know he wants to update the HEMCO in GEOS soon, so we might have an opportunity.
@mathomp4 mathomp4 added the enhancement New feature or request label Mar 9, 2022
@mathomp4 mathomp4 self-assigned this Mar 9, 2022
This was referenced Mar 10, 2022
Merged
Merged
Merged
Merged
Merged
Merged
mathomp4 added a commit that referenced this issue Mar 17, 2022
@mathomp4
Fixes #387. Updates for Spack Support
a97e65d
@mathomp4 mathomp4 mentioned this issue Mar 17, 2022
Merged
sdrabenh added a commit that referenced this issue Mar 18, 2022
@sdrabenh
Merge pull request #394 from GEOS-ESM/feature/mathomp4/spack
e6d617b 
Fixes #387. Updates for Spack Support
@mathomp4 mathomp4 reopened this Mar 18, 2022
mathomp4 added a commit to GEOS-ESM/GOCART that referenced this issue Mar 21, 2022
@mathomp4
Updates for Spack Support, Round 2
53fbeaa 
Due to insufficient grepping on my part, some remnants of the
"not-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
@mathomp4 mathomp4 mentioned this issue Mar 21, 2022
Merged
mathomp4 added a commit to GEOS-ESM/GEOS_OceanGridComp that referenced this issue Mar 21, 2022
@mathomp4
Updates for Spack Support, Round 2
fb414b1 
Due to insufficient grepping on my part, some remnants of the
"not-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
@mathomp4 mathomp4 mentioned this issue Mar 21, 2022
Merged
mathomp4 added a commit to GEOS-ESM/GEOSchem_GridComp that referenced this issue Mar 21, 2022
@mathomp4
Updates for Spack Support, Round 2
77e3bcb 
Due to insufficient grepping on my part, some remnants of the
"non-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
mathomp4 added a commit to GEOS-ESM/GEOSgcm_GridComp that referenced this issue Mar 21, 2022
@mathomp4
Updates for Spack Support, Round 2
7c2c517 
Due to insufficient grepping on my part, some remnants of the
"non-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
This was referenced Mar 21, 2022
Merged
Merged
mathomp4 added a commit to GEOS-ESM/GFDL_atmos_cubed_sphere that referenced this issue Mar 21, 2022
@mathomp4
Updates for Spack Support, Round 2
2168fc2 
Due to insufficient grepping on my part, some remnants of the
"non-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
@mathomp4 mathomp4 mentioned this issue Mar 21, 2022
Merged
mathomp4 added a commit to GEOS-ESM/FVdycoreCubed_GridComp that referenced this issue Mar 21, 2022
@mathomp4
Updates for Spack Support, Round 2
6f8c5e6 
Due to insufficient grepping on my part, some remnants of the
"non-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
@mathomp4 mathomp4 mentioned this issue Mar 21, 2022
Merged
sanAkel pushed a commit to GEOS-ESM/GEOS_OceanGridComp that referenced this issue Mar 22, 2022
@mathomp4
Updates for Spack Support, Round 2 (and add CircleCI) (#1)
257f871 
* Updates for Spack Support, Round 2

Due to insufficient grepping on my part, some remnants of the
"not-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.

* Add CI
This was referenced Mar 22, 2022
Merged
Merged
@mathomp4 mathomp4 mentioned this issue Mar 31, 2022
Merged
mathomp4 added a commit to GEOS-ESM/TR that referenced this issue Jan 6, 2023
@mathomp4
Updates for Spack Support, Round 2
2f34da9 
Due to insufficient grepping on my part, some remnants of the
"non-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
mathomp4 added a commit to GEOS-ESM/GMI that referenced this issue Jan 6, 2023
@mathomp4
Updates for Spack Support, Round 2
ea0cc66 
Due to insufficient grepping on my part, some remnants of the
"non-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
mathomp4 added a commit to GEOS-ESM/MATRIX that referenced this issue Apr 27, 2023
@mathomp4
Updates for Spack Support, Round 2
ac505f6 
Due to insufficient grepping on my part, some remnants of the
"non-canonical" CMake still remain. Apparently these were not necessary
changes for Spack, but they are changes that unify the CMake style of
GEOS to be more like "correct" CMake.

In this go-around, it is mainly finding `INC_ESMF` which I apparently
forgot to grep for last time (I was focused on NetCDF), and some
non-canonical OpenMP calls.

See GEOS-ESM/GEOSgcm#387 for the meta-issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathomp4 mathomp4

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #387. Updates for Spack Support GEOS-ESM/GEOSgcm
1 participant
@mathomp4