Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support Spack #170

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Updates to support Spack #170

merged 2 commits into from
Mar 18, 2022

Conversation

mathomp4
Copy link
Member

This zero-diff PR has build system changes to support the use of Spack. Most of the changes just make the GEOS CMake look more like canonical CMake. GEOS previously couldn't support this, but it now can.

See GEOS-ESM/GEOSgcm#387 for overall issue.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Mar 10, 2022
@mathomp4 mathomp4 self-assigned this Mar 10, 2022
@mathomp4
Copy link
Member Author

Scott has pulled in GEOS-ESM/GEOSgcm#388. Therefore, I feel safe undrafting this.

@mathomp4 mathomp4 marked this pull request as ready for review March 17, 2022 17:09
@mathomp4 mathomp4 requested review from a team as code owners March 17, 2022 17:09
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok

Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero diff, and CMake more canonical -- approved.

@mmanyin
Copy link
Contributor

mmanyin commented Mar 17, 2022

@tclune - please approve

@tclune tclune requested review from tclune and mmanyin March 18, 2022 12:40
@mmanyin mmanyin merged commit af2625a into develop Mar 18, 2022
@mmanyin mmanyin deleted the feature/mathomp4/spack branch March 18, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants