Step execution from suspended state #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach type checks and seems like it could work, but it is difficult to know until we try it on an example. We are assuming that: 1. When the simulator issues a call to our override, it pushes a `VFFEnd` frame onto the execution tree. This contains the directions on how to return to the caller (e.g., what return type is expected and what statements remain to execute). 2. From our override, we only know how to return Unit, which we prove to the type checker by pattern matching on the return type repr. The other cases will be errors (hopefully with better reporting than calling `error`)
travitch
added a commit
that referenced
this pull request
Dec 29, 2020
…frame This change completes Vikraman's sketch of the functionality. It: - Removes the error calls (replacing them with logging) - Simplifies the single stepping implementation - Redesigns the symbolic execution state management and rendering The issue with the state management was that symbolic execution state was duplicated between the core and the brick UI in a way that allowed them to get out of sync. This mean that changes to the core state (e.g., as users advance the suspended state via commands) were not reflected in the UI (as the UI state was stale). To fix this, all updates to the symbolic execution state now go through a new distinguished message (the handler for which applies the update). This allows the frontends to apply additional processing to observe all of these updates and regenerate the UI state whenever there is a relevant update. This also simplifies the symbolic execution widget, which now only returns its own updated state (and handles any state updates via message passing). Some other changes included with this change: - There is an option for adding calling context information for generated log entries - Extracts the core symbolic execution state handlers and puts them back into the core where they belong - Make symbolic execution session state updates safer (remove mergeSessionState) Closes #74 (integrated with these changes)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72