Async audio messages/audio recording #4658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
force-pushed
the
async_audio_messages/audio_recording
branch
from
ab475f0
to
a0eeebb
Compare
|
DB Entities have been updated. Do we need to upgrade DB Version? |
…d simplify recording media using Android's `MediaRecorder` - [4654] Implement a public `StreamFileUtil` method used for creating a new file inside the cache directory
…pe of `DefaultStreamMediaRecorder` - [4654] Create `StreamMediaRecorderStateHolder` used for holding and propagating state events emitted from the `MediaRecorder` used internally by `StreamMediaRecorder`
…y proof of concept integration with `MessageComposer`
…y proof of concept integration with `MessageComposer`
…corderStateManager` and give it more direct governing capabilities over `StreamMediaRecorder`
…corderStateManager` and give it more direct governing capabilities over `StreamMediaRecorder`
…ingWaveForm` - [4654] Create a new state class designed to track `StreamMediaRecorder` states with the appropriate listener functional interfaces and setter method inside `StreamMediaRecorder` - [4654] Create max amplitude polling listener functional interface and setter method inside `StreamMediaRecorder` and a polling mechanism inside `DefaultStreamMediaRecorder`
…d also be Activity lifecycle dependent so it's a better design decision to let users provide it in the Activity the Chat is embedded in - [4654] Rename `StreamMediaRecorderStateManager` to `StatefulStreamMediaRecorder` and expose `StreamMediaRecorder`'s functions without exposing `StreamMediaRecorder` itself - [4654] Introduce `StatefulStreamMediaRecorder` to `MessageComposer` and `MessagesScreen` composables - [4654] Introduce `KeyValuePair`, a facsimile of Kotlin's Pair but with more descriptive naming -
…ration in `StreamMediaRecorder` and `StatefulStreamMediaRecorder` - [4654] Release the media recorder if the start or stop methods fail
… were asked for and the user chose an option and optimize escaping function when appropriate. - [4654] Improve recording reliability by starting recording only once the pointer event scope has been acquired.
kanat
force-pushed
the
async_audio_messages/audio_recording
branch
from
a0eeebb
to
f79ce04
Compare
16 tasks
|
Will be a part of #4828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Describe why we are making this change
🛠 Implementation details
Describe the implementation
🎨 UI Changes
Add relevant screenshots
Add relevant videos
🧪 Testing
Explain how this change can be tested (or why it can't be tested)
Provide a patch below if it is necessary for testing
Provide the patch summary here
☑️Contributor Checklist
General
developbranchCode & documentation
☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request