Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i74] support async voice messages in Android XML #4828

Merged
merged 145 commits into from
Jul 12, 2023
Merged

[i74] support async voice messages in Android XML #4828

merged 145 commits into from
Jul 12, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented May 23, 2023 •
edited
Loading

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/74
Relates to:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat changed the title Feature/async audio message [i74] support async voice messages in Android XML Jul 7, 2023
@kanat kanat marked this pull request as ready for review July 7, 2023 01:08
@kanat kanat requested a review from a team as a code owner July 7, 2023 01:08
This was referenced Jul 10, 2023
Closed
Closed
@kanat kanat requested a review from JcMinarro July 11, 2023 06:23
@kanat kanat added feature request ui-components core v6-beta An issue for targeting v6-beta labels Jul 11, 2023
JcMinarro
JcMinarro approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@JcMinarro JcMinarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big PR.
Overall it looks good.
Some tasks can be achieved later and not block it anymore

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt Show resolved Hide resolved
...d-compose/src/main/java/io/getstream/chat/android/compose/ui/composables/AudioWaveSeekbar.kt Show resolved Hide resolved
kanat and others added 21 commits July 12, 2023 13:47
@JcMinarro
[i74] fix recording being missed from attachment
07e894d
@JcMinarro
[i74] fix guides & UT
d1e30bf
@JcMinarro
[i74] add ui style & validation of blocked upload formats
44c0ec5
@JcMinarro
[i74] enable audio recording in sample app
4da66fe
@JcMinarro
[i74] fix night styling
ce1273d
@JcMinarro
[i74] disable audio recording in compose
88a0828
@JcMinarro
[i74] mark player as an internal api
5a7f957
@JcMinarro
[i74] added changelog
b99a5e3
@JcMinarro
[i74] rename AudioRecordsGroupView
1f4f3b0
@JcMinarro
[i74] spotless, detekt, api-dump
aad9e54
@JcMinarro
[i74] fix unit tests
4ff297b
@JcMinarro
Move Recording class to proper package
4e780e4
@JcMinarro
[i74] fix jumping layout size
ff000e7
@JcMinarro
[i74] keep showing lock icon after screen rotation
967055e
@JcMinarro
[i74] add ability to select between 1 or 2 buttons
70d5eee
@JcMinarro
[i74] add kdocs
07d3f2c
@JcMinarro
[i74] delete dead code
338330f
@JcMinarro
[i74] fix UT & add missing style attrs
ba4b685
@JcMinarro
[i74] add audio recording guide
252371d
@JcMinarro
Ignore docusaurus shared folder
5f0ffe5
@JcMinarro
Remove translations
768e120
@JcMinarro JcMinarro force-pushed the feature/async-audio-message branch from 0f12949 to 768e120 Compare July 12, 2023 11:52
@JcMinarro JcMinarro enabled auto-merge (rebase) July 12, 2023 11:52
@JcMinarro JcMinarro merged commit 839f32d into develop Jul 12, 2023
7 checks passed
@JcMinarro JcMinarro deleted the feature/async-audio-message branch July 12, 2023 12:22
This was referenced Jul 26, 2023
Merged
Merged
@kanat kanat mentioned this pull request Aug 8, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
core feature request ui-components v6-beta An issue for targeting v6-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kanat @JcMinarro @leandroBorgesFerreira @MarinTolic