Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-4741] Implement audio playback Core & UI #4748

Closed

Conversation

leandroBorgesFerreira
Copy link
Contributor

@leandroBorgesFerreira leandroBorgesFerreira commented Mar 23, 2023

🎯 Goal

Implement audio messages playback. This is a preview of the future that may change once the final specs are ready.

🛠 Implementation details

  • Adding a new type of message.
  • Adding StreamAudioPlayer that coordinates the audio play.

Note1: Customization is not implemented. Let's add this once the final version of the async audio feature is decided and all the specs are documented.

Note2: It is not possible to play a message in the MessageComposer using the file path (before sending it to the backend), only the assertUrl is available (when editing the message). I leave this to the record part of this feature.

🎨 UI Changes

Screenshot 2023-03-28 at 15 09 29

New message type available

🧪 Testing

Go to the channel Junior Big and check the audio messages available there.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes - after release.
  • [ ] New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial). todo

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

giphy (5)

@leandroBorgesFerreira leandroBorgesFerreira marked this pull request as ready for review March 28, 2023 13:04
@leandroBorgesFerreira leandroBorgesFerreira changed the title [ISSUE-4741] Implement audio playback UI [ISSUE-4741] Implement audio playback Core & UI Apr 2, 2023
@kanat
Copy link
Collaborator

kanat commented Jul 10, 2023

Will be a part of #4828

@kanat kanat closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants