-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-4741] Implement audio playback Core & UI #4748
Closed
leandroBorgesFerreira
wants to merge
60
commits into
develop
from
ISSUE-4741/ImplementAudioPlaybackUi
Closed
[ISSUE-4741] Implement audio playback Core & UI #4748
leandroBorgesFerreira
wants to merge
60
commits into
develop
from
ISSUE-4741/ImplementAudioPlaybackUi
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroBorgesFerreira
force-pushed
the
ISSUE-4741/ImplementAudioPlaybackUi
branch
from
March 24, 2023 12:24
50853fb
to
9dd7797
Compare
leandroBorgesFerreira
force-pushed
the
ISSUE-4741/ImplementAudioPlaybackUi
branch
from
March 30, 2023 16:53
a9086b0
to
a74774a
Compare
leandroBorgesFerreira
changed the title
[ISSUE-4741] Implement audio playback UI
[ISSUE-4741] Implement audio playback Core & UI
Apr 2, 2023
16 tasks
Will be a part of #4828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Implement audio messages playback. This is a preview of the future that may change once the final specs are ready.
🛠 Implementation details
Note1: Customization is not implemented. Let's add this once the final version of the async audio feature is decided and all the specs are documented.
Note2: It is not possible to play a message in the MessageComposer using the file path (before sending it to the backend), only the
assertUrl
is available (when editing the message). I leave this to the record part of this feature.🎨 UI Changes
New message type available
🧪 Testing
Go to the channel Junior Big and check the audio messages available there.
☑️Contributor Checklist
General
develop
branchCode & documentation
[ ] New code is covered by unit tests☑️Reviewer Checklist
🎉 GIF