chore: Update CODEOWNERS #3931
chore: Update CODEOWNERS #3931
Conversation
Cloud SQL samples ownership has moved from Cloud SDK back to Cloud SQL and as such the `infra-db-sdk` team should instead be `cloud-sql-connectors` Will need someone to give write access to @GoogleCloudPlatform/cloud-sql-connectors on this repo for the CODEOWNERS file to be happy
![code-review-assist-experimental[bot]](https://avatars.githubusercontent.com/in/919852?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @jackwotherspoon,
I'm currently reviewing this pull request and will have a full review for you in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed.
This PR updates the CODEOWNERS file to reflect the change in ownership of the Cloud SQL samples. Specifically, the ownership of the cloud-sql section has been transferred from the @GoogleCloudPlatform/infra-db-sdk team to the @GoogleCloudPlatform/cloud-sql-connectors team. This is a straightforward change, updating a single line in the CODEOWNERS file (line 31). The PR description notes that write access will need to be granted to the cloud-sql-connectors team on this repository for the change to take full effect.
As a side note, I'd like to share a little haiku to brighten your day:
Code flows like a stream,
Owners shift, a gentle change,
Docs now find their home.
Looking forward to completing the review shortly!
product-auto-label
bot
added
the
samples
There was a problem hiding this comment.
This pull request updates the CODEOWNERS file to reflect the change in ownership of Cloud SQL samples from the infra-db-sdk team to the cloud-sql-connectors team. This is a necessary change to ensure that the correct team is notified of changes to the Cloud SQL samples. The PR description mentions needing write access granted to the cloud-sql-connectors team. Please ensure this access is granted before merging. Additionally, consider adding a brief entry to the relevant README files explaining the team responsible for the Cloud SQL samples for better discoverability.
| @@ -28,7 +28,7 @@ tpu @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers | |||
| webrisk @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers | |||
|
|
|||
| # SoDa teams | |||
| cloud-sql @GoogleCloudPlatform/infra-db-sdk @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers | |||
| cloud-sql @GoogleCloudPlatform/cloud-sql-connectors @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers | |||
There was a problem hiding this comment.
This change correctly updates the owner for the cloud-sql samples. Is there any other related documentation that needs updating to reflect this ownership change?
Cloud SQL samples ownership has moved from Cloud SDK back to Cloud SQL and as such the
infra-db-sdkteam should instead becloud-sql-connectorsWill need someone to give write access to @GoogleCloudPlatform/cloud-sql-connectors on this repo for the CODEOWNERS file to be happy.