Fixes #1861: Make the entire like layout clickable vs just the text #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jsoberg, thanks a bunch for this tweak! Really smart move to make the entire layout clickable – it's little changes like these that can make a big difference, especially for accessibility. As for the touch target size - good call! I think keeping Google's guidelines in mind is super important. We might play around with the sizing down the line, but for now, what you've done is spot on. TY! |
|
Thanks @Hafizzle! I love the app btw, I'm hoping to contribute more regularly as time permits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously just the text itself was clickable here, so I made the parent layout clickable instead. Ideally this layout would be a bit larger for a11y reasons, Google recommends 48dp minimum touch target size (link) but I left the sizing as-is for now.
my Habitica User-ID:
caef89d8-3a3d-4d3b-a5ad-67cb0455a56e