Add workflow for running checks on pushes and PRs #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Downgrade eslint version to be compatible with eslint-config-next - Move eslint from root to individual packages - Move some site dependencies to devDependencies
- Add Actions workflow for running checks, adapted from irvinehacks-site - Upgrade pnpm version specified in `packageManager` to match lockfile
|
Deploy preview for zothacks-site-2023-sanity ready!
|
|
Looks like ESLint is now properly enforced during |
|
Deploy preview for zothacks-site-2023 ready!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #182 and as part of #164.
Right now, only the workflow is created, the actual ESLint configuration still needs to be updated (to be handled separately). The preview deployment initially failing demonstrates that ESLint is now properly enforced during
next build(was because of some lingering issues with react/no-unescaped-entities).Changes
dependenciestodevDependenciespackageManagerto match lockfile