Use a different separator for sed 's' command #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sed expression that is used to set specific config values doesn't work while trying to set the following config: CONFIG_ANDROID_BINDER_DEVICES="binder,hwbinder,vndbinder,anbox-binder,anbox-hwbinder,anbox-vndbinder" Instead, it throws the following error: sed: -e expression Halium#1, char 80: unknown option to `s' This is because the argument separator (comma) also appears in the expression argument itself. That causes sed to interpret the 'h' in 'binder,hwbinder' as an option to the 's' command. This change makes semicolon (;) the separator instead of comma (,) to avoid the issue. If a new config value with a semicolon in it is ever added to the list in $CONFIGS_EQ, this will have to be changed.
|
Is this PR in the wrong place? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sed expression that is used to set specific config values doesn't work while trying to set the following config:
CONFIG_ANDROID_BINDER_DEVICES="binder,hwbinder,vndbinder,anbox-binder,anbox-hwbinder,anbox-vndbinder"Instead, it throws the following error:
sed: -e expression # 1, char 80: unknown option to 's'This is because the argument separator (comma) also appears in the expression argument itself. That causes sed to interpret the
hinbinder,hwbinderas an option to thescommand.This change makes semicolon (
;) the separator instead of comma (,) to avoid the issue. If a new config value with a semicolon in it is ever added to the list in$CONFIGS_EQ, this will have to be changed.